refs #26133 [fid] release/fid_bbi/2024_01 remove home library from session storage after updating user

* home library is not enity-connected with user-dto
* libraries are requested via string-identifier and stored in session

Robert Lange authored 1 year ago and Mathias Maaß committed 1 year ago

* do not proxify local_addresses
* use Laminas http client in fid client
* do not use vufindhttp-psrcompat and zend-psr18bridge
* simplify: remove sendAuthenticatedRequest and buildRequest => senRequest
* refresh logon after 401 (when stale?)
* add comment and set headers always by key => value
* deactivate SSL_VERIFY for fidis request
* fix options for ssl
* do not retry refreshLogon

Robert Lange authored 1 year ago and Mathias Maaß committed 1 year ago

* update composer, use latest finc/vufindhttp-psrcompat version
* replace Zend by Laminas in php
* use laminas instead of Zend i18n resources
* use updated module for permission provider
* add translation for label_access_level_basic_access
* replace Zend by Laminas
* fix hydrator - use Laminas\Hydrator\ClassMethodsHydrator
* fix hydrator - use Laminas\Hydrator\ClassMethodsHydrator, adapt doc
* fix hydrator - use Laminas\Hydrator\ClassMethodsHydrator, adapt doc
* add csp ini
* convert inline script to Head script
* adjust UserDataStrategy hydrate-method (maybe php7 problem only)
** failure at creating user and edit user data by admin
** prevent error: Too few arguments to function fid\Hydrator\Strategy\UserDataStrategy::hydrate()
* adapt menu.phtml from finc
** add missing menu entries
* add hydrator's extract-method return type
* improve default config
** show createdAt-field in user list by default
** activate order export by default
* add missing closing tag

* get working mapping of item-respons-json to DTO user by adding set-method
* adding formatted date in table row

* no security question as of now
* wont work without expansion of fidis
* added route for order deletion (requires admin rights)
* config parameters displayCols defines, 'delete' for the delete button
* using font awesome for the fa-trash symbol, can be overwritte in field-delete.html
* design changes for orderDelete
* Code Stlye changes to Delete Order Modal
** Modal has its own template now, only rendered when activated via config
** fixed a bug where the default fid delete button would have missed crucial info and had just outright deleted the entry
** known problem: the delete route is actually reacheable for any one user but will be rebuffed by fidis itself, still not entirely clean

* config variable name
* data transfer object user now has functionality to filter whitespace in orders
* fid.ini got out-commented variable field for user export fields in [Admin] section
* updated user export behaviour, field 'orders' will now always be the last in an export
* introduced an user export hydrator that enriches data for export into csv and json files
* further altered the interface and handling of various csv flavors, prepared work for an unified
* export interface to a future date, created adlr exporting to stated specs
* introduced an user export hydrator that enriches data for export into csv and json files
* further altered the interface and handling of various csv flavors, prepared work for an unified
* export interface to a future date, created adlr exporting to stated specs
* added some language tokens for better integration
* updated json export to make the address list a associative array

co-authored by: Robert Lange <robert.lange@uni-leipzig.de>
* o...

* refactored logic for fidis orders, formerly living in the UserController, seperated User and Order Controller
* added an (by default hidden) export option for orders)
* extended abilities of order transfer object
* added an order export hydrator that compiles data of an order to an array
* extended the order list with a button that is hidden by default (if 'export_button' is not set)
* allows export of orders in 3 different flavor of CSV (or rather, fake csv that is labelled as txt) and json.
* language vars replaced some static texts with dynamic i18n ones, in this particular case the button descriptions of are affected

* usage of rules evaluator and GetItRules.yaml in instance
* add temp check with old implementation - TODO: remove with 22011

* fix status on invalid session state, also refs #22043
** throw UserNotAuthorizedException on 401
** on 401 logout in RecordController homeAction

* devops info:
** run "./install-codestylechecker.sh install" to install dependencies for git hooks code style checks
** see https://projekte.ub.uni-leipzig.de/projects/finc-intern/wiki/Code-Quality-Checking_mit_PHPStorm#section-5 for integration of CS Fixer validation in PHPStorm
* $HOME/bin/codestylechecker/php-cs-fixer3 fix --config=$HOME/bin/codestylechecker/vufind.php-cs-fixer.php_cs module/fid/src/
* add missing class and method comments
* move view helper classes to correct directory
* run codesniffer-beautifier for modules and templates

co-authored by: Dorian Merz <merz@ub.uni-leipzig.de>
co-authored by: Alexander Purr <purr@ub.uni-leipzig.de>

refs #21063 [fid] changes after using PHP CS Fixer 3.1.0 instead of 2.14.0 (friendsofphp/php-cs-fixer)

* PHP CS Fixer 3.1.0 is used in VuFind8
* working just with test/vufind.php-cs-fixer.php ruleset from VuFind8
** with updated ruleset
** some rule names / settings changed because of fixer version
* running by command:
** ../VuFind8/vendor/bin/php-cs-fixer fix --config=../VuFind8/tests/vufind.php-cs-fixer.php module/fid

* vendor/bin/phpcbf --standard=tests/phpcs.xml module/fid/
* vendor/bin/php-cs-fixer fix --config=tests/vufind.php_cs module/fid
* using PHP_CodeSniffer 3.6.2 instead of 3.4.0 (squizlabs/php_codesniffer)

* new Client methods:
** get order (uses fidis GET resource)
** update order (is complemented by fidis PUT resource - ticket 20690)
* add new route for EditOrder
* new UserController methods
** editOrderAction -> loads order, form-config & view; checks EditOrder-Permission
** updateOrder
** applyStatusOptions for correct prefilling and translate of status options
* new form-configs for simple (only status) and complete (status and due date) form
* new configuration blocks in fid.ini (disabled)
** OrderList section for displaying additional columns in order list table
** Edit section (depending on order type - here pda and digitization) sets form type (basic / complete) and possible status options
* templates
** add configured columns (like type, status, due date, edit button) on admin order list (and nested templates)
** new edit order main template (incl. some order information)
** new basic and complete form template
* add getter and setter (status, due date) on DTO order
* create updateOrderHydrator
** used for prefilling form and update order object before requesting fidis
* new translations

* add preconfigured default status on creating an order / acquisition (via trait and order hydrator)

* add template acquisition-contact-details.phtml from bbi
** used in pda action
** used in edit order action

* add translation for order type

* always show current status of order in order list
** by force reload user data inclusive orders in controller action

* allow null value on setting order status

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* enable comment field for pda
** in controller
** in hydrator
* check complete address

* allow multi-step form by saving and retrieving followup url
* prevent hiding pda form in lightbox after redirect from profile update - SuccessMessage of flash messenger would disable displaying pda form

* add action in User Controller
* add form for password confirmation
* check credentials in Client
* add properties in User dto for deletion
* check for deleted property on login in Authenticator
* add default translation texts
* add template for success message
* redirect to home page after closing of modal

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* set method get newsletter bool

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* using reload flag within user details request to force refresh
* do not save order list in session any more

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* remove manual save of order to user session

* preprocess whole config in mvc event listener
* handle the case of forbidden base url override
* render fidis status in fixed footer

* forbid base url overrides by default and allow in alpha environments
* override base url via separate mvc event listener
* print effective fidis base url in footer

Gregor Gawol authored 5 years ago and Dorian Merz committed 5 years ago

* set client function
* set get it box function
* set some translations

Alexander Purr authored 5 years ago and Dorian Merz committed 5 years ago

* speed up csv export by limit fidis user request to one
** response contains complete user list inclusive all relevant details
** see also #16938
* export file as *.txt
* display phone number in user export

* generates tab separated values file for download
* export all fields

Sebastian Kehr authored 5 years ago and Dorian Merz committed 5 years ago

* fix: properly handle empty user data on hydration
* add missing translations
* account for anonymous logons on authorization
* remove headline in template

Alexander Purr authored 5 years ago and Dorian Merz committed 5 years ago

* supplies Libero ID via User DTO

Alexander Purr authored 5 years ago and Dorian Merz committed 5 years ago

* citation is pre formatted with HTML and used in view
* add order to session saved user
* provides complete order list (even newest orders)
* create common getOrderLabel function

Alexander Purr authored 5 years ago and Dorian Merz committed 5 years ago

* get delivery address direct via DTO User
* template adjustments
* show additionally college if business address is used

Sebastian Kehr authored 5 years ago and Dorian Merz committed 5 years ago

* add xdebug related headers to fidis requests
* update composer.lock

Sebastian Kehr authored 5 years ago and Dorian Merz committed 5 years ago

* add label attribute to order dto
* adjust order templates to display order label

Robert Lange authored 5 years ago and Dorian Merz committed 5 years ago

* set library list in session correctly in method requestLibraryList
* add method 'requestLibraryById' for getting single library from api

* introduces new Exception types
* uses those Exceptions to authorize user

Sebastian Kehr authored 5 years ago and Dorian Merz committed 5 years ago

* initial refactoring to use address fieldsets on user creation and update
* generalize user creation form
** allow for multiple addresses in more flexible ways
** introduce general radio fields for user groups
* reuse dto on user creation with the help of zend-hydrator
* adjust user update form
* use hydrator for all user forms
* fixup to user init method
* add gpl license header
* remove empty home library option from user update form
* remove imports of non-existing classes
* custom submit label in user update form
* pass library list with ils authenticator
* rename property for less confusion
* implement possibly required ils authenticator method
* render address id field only if value non-empty
* convert user data property names to camel case via custom strategy
* pass root input filter with context to nested input filters
* relax requirements for first mandatory user address
* first fixes to admin edit form
* completely specify admin edit form in its own file
* include job title field in admin edit form
* revision of admin edit form

Sebastian Kehr authored 5 years ago and Dorian Merz committed 5 years ago

* allow for multiple addresses
* use correct validator method and address index
* remove type attribute
* adjust profile view w.r.t. empty addresses
* reintroduce form label helper to account for required attributes
* let second address line be optional