refs #26133 [fid] release/fid_bbi/2024_01 remove home library from session storage after updating user

* home library is not enity-connected with user-dto
* libraries are requested via string-identifier and stored in session

Robert Lange authored 1 year ago and Mathias Maaß committed 1 year ago

* do not proxify local_addresses
* use Laminas http client in fid client
* do not use vufindhttp-psrcompat and zend-psr18bridge
* simplify: remove sendAuthenticatedRequest and buildRequest => senRequest
* refresh logon after 401 (when stale?)
* add comment and set headers always by key => value
* deactivate SSL_VERIFY for fidis request
* fix options for ssl
* do not retry refreshLogon

Alexander Purr authored 1 year ago and Mathias Maaß committed 1 year ago

* add noLinking option to Authors/Corporations in FidAcquisitionSpec
* add no-linking logic in data-authors.phtml

* add default parameter for createExportFile method to en-/disable of printing table header

* more consistent now

Robert Lange authored 1 year ago and Mathias Maaß committed 1 year ago

* update composer, use latest finc/vufindhttp-psrcompat version
* replace Zend by Laminas in php
* use laminas instead of Zend i18n resources
* use updated module for permission provider
* add translation for label_access_level_basic_access
* replace Zend by Laminas
* fix hydrator - use Laminas\Hydrator\ClassMethodsHydrator
* fix hydrator - use Laminas\Hydrator\ClassMethodsHydrator, adapt doc
* fix hydrator - use Laminas\Hydrator\ClassMethodsHydrator, adapt doc
* add csp ini
* convert inline script to Head script
* adjust UserDataStrategy hydrate-method (maybe php7 problem only)
** failure at creating user and edit user data by admin
** prevent error: Too few arguments to function fid\Hydrator\Strategy\UserDataStrategy::hydrate()
* adapt menu.phtml from finc
** add missing menu entries
* add hydrator's extract-method return type
* improve default config
** show createdAt-field in user list by default
** activate order export by default
* add missing closing tag

* get working mapping of item-respons-json to DTO user by adding set-method
* adding formatted date in table row

* changed ezb resolver version of fid to only transmit one identifier for a library
* also corrected url encoded typo that apparently crashed the entire API

* there were some slight individual changes that made them not working at the same time
* changed private getContext() Funktion to protected to allow overwritting

co-authored by: Robert Lange <robert.lange@uni-leipzig.de>
* remove old accordeon variables

* no security question as of now
* wont work without expansion of fidis
* added route for order deletion (requires admin rights)
* config parameters displayCols defines, 'delete' for the delete button
* using font awesome for the fa-trash symbol, can be overwritte in field-delete.html
* design changes for orderDelete
* Code Stlye changes to Delete Order Modal
** Modal has its own template now, only rendered when activated via config
** fixed a bug where the default fid delete button would have missed crucial info and had just outright deleted the entry
** known problem: the delete route is actually reacheable for any one user but will be rebuffed by fidis itself, still not entirely clean

* config variable name
* data transfer object user now has functionality to filter whitespace in orders
* fid.ini got out-commented variable field for user export fields in [Admin] section
* updated user export behaviour, field 'orders' will now always be the last in an export
* introduced an user export hydrator that enriches data for export into csv and json files
* further altered the interface and handling of various csv flavors, prepared work for an unified
* export interface to a future date, created adlr exporting to stated specs
* introduced an user export hydrator that enriches data for export into csv and json files
* further altered the interface and handling of various csv flavors, prepared work for an unified
* export interface to a future date, created adlr exporting to stated specs
* added some language tokens for better integration
* updated json export to make the address list a associative array

co-authored by: Robert Lange <robert.lange@uni-leipzig.de>
* o...

* refactored logic for fidis orders, formerly living in the UserController, seperated User and Order Controller
* added an (by default hidden) export option for orders)
* extended abilities of order transfer object
* added an order export hydrator that compiles data of an order to an array
* extended the order list with a button that is hidden by default (if 'export_button' is not set)
* allows export of orders in 3 different flavor of CSV (or rather, fake csv that is labelled as txt) and json.
* language vars replaced some static texts with dynamic i18n ones, in this particular case the button descriptions of are affected

* move rss helper to fid
** uses caching
** code styles

co-authored by: Alexander Purr <purr@ub.uni-leipzig.de>
* make get-it-box view helper factory reusable in instances

* see also 21615

Jean-Pascal Kanter authored 2 years ago and André Lahmann committed 2 years ago

* temporary restauration of getit.ini
* disabled get it legacy check
* multiple fixes in getitrules.yaml

Jean-Pascal Kanter authored 2 years ago and André Lahmann committed 2 years ago

* so called 'permissions' where a kind of configuration for the general availability of services
* those settings was the last remnant of the getit.ini
- deleted getit.ini
+ added configuration part of those 4 settings to the GetItRules.yaml as 'conf_allow*'

* do not extend obsolete vufind factory - now plugin

* usage of rules evaluator and GetItRules.yaml in instance
* add temp check with old implementation - TODO: remove with 22011

* fix status on invalid session state, also refs #22043
** throw UserNotAuthorizedException on 401
** on 401 logout in RecordController homeAction

* copied nearly complete functionality introduced to adlr in ticket 16184 to fid branch
* adapt admins form for editing users
* set deleted flag to false on user registration (as default)
* show deleted info in admin user view
* configurable
* switch auth error message order
** dispay deleted account message before check on blocked account
** accounts can be blocked without flagging for removal

* adding abstract translation
* add default translation for homepage, volume and year
* build translation key within template

* EZB-Resolver:
** save access state to each ezb resolver result
** reuse getElectronicResults removed in ticket 20764
* ResolverLinks helper hands over print- or electronic results to templates instead of prepared access and message information
* handle access (article order button) and messaging in templates now
** messages are generated by type (electronic / print and access state)
* improve array merging in template resolverLinks-print.phtml

* change parseLinks method: differs from inherited finc ezb resolver by not requesting print state 10

* allowing empty comments on pda/print
* building type translation keys with _ instead of -
* fix method signature for isValid() to fit interface - can not change param of simple type mixed to string
* do not show user name in users order list
* create order edit form only if order type has form configuration in fid.ini

* occurred while fid refactoring - fix code style (see ticket 21064)
* https://projekte.ub.uni-leipzig.de/projects/vufind-projekte/repository/vufind/revisions/f7bc6bc1159582b420b211c0f4a2427fce205f28/diff/module/fid/src/Controller/CustomTraits/FidAcquisitionTrait.php

refs #20655 [fid] create some separate column field templates and split column configuration for user and admin order list

* due date
* edit

* use OrderList->displayCols array in fid.ini for activation and ordering columns
* configuration is uses for order listing in user and admin view
* restructure templating for best re-usage and less code
* move templates into fid/order directory
* add missing section in fid.ini
* using renderInContext to retain parent's template variables too
* hide empty lines / entries in renderArray-helper for displaying properties of free digitization-on-demand

* introduced translation domain for GetItBox
* refactored templates to use GetItBox domain
* refactored state logic in resolverLinks-button.phtml to work with standardized VuFind access states
* refactored and aligned GetResolverLinks->handleRequest with finc version
* remove fetchLinks from EZB, use parent

* devops info:
** run "./install-codestylechecker.sh install" to install dependencies for git hooks code style checks
** see https://projekte.ub.uni-leipzig.de/projects/finc-intern/wiki/Code-Quality-Checking_mit_PHPStorm#section-5 for integration of CS Fixer validation in PHPStorm
* $HOME/bin/codestylechecker/php-cs-fixer3 fix --config=$HOME/bin/codestylechecker/vufind.php-cs-fixer.php_cs module/fid/src/
* add missing class and method comments
* move view helper classes to correct directory
* run codesniffer-beautifier for modules and templates

co-authored by: Dorian Merz <merz@ub.uni-leipzig.de>
co-authored by: Alexander Purr <purr@ub.uni-leipzig.de>

refs #21063 [fid] changes after using PHP CS Fixer 3.1.0 instead of 2.14.0 (friendsofphp/php-cs-fixer)

* PHP CS Fixer 3.1.0 is used in VuFind8
* working just with test/vufind.php-cs-fixer.php ruleset from VuFind8
** with updated ruleset
** some rule names / settings changed because of fixer version
* running by command:
** ../VuFind8/vendor/bin/php-cs-fixer fix --config=../VuFind8/tests/vufind.php-cs-fixer.php module/fid

* vendor/bin/phpcbf --standard=tests/phpcs.xml module/fid/
* vendor/bin/php-cs-fixer fix --config=tests/vufind.php_cs module/fid
* using PHP_CodeSniffer 3.6.2 instead of 3.4.0 (squizlabs/php_codesniffer)

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* check if order has solr record / record driver
* if not: display record information given by user
* add default status on digitization without solr record

* change visibility of helper functions
* allow for ALL keyword in sources list

* change visibility of helper functions
* allow for ALL keyword in sources list

* new Client methods:
** get order (uses fidis GET resource)
** update order (is complemented by fidis PUT resource - ticket 20690)
* add new route for EditOrder
* new UserController methods
** editOrderAction -> loads order, form-config & view; checks EditOrder-Permission
** updateOrder
** applyStatusOptions for correct prefilling and translate of status options
* new form-configs for simple (only status) and complete (status and due date) form
* new configuration blocks in fid.ini (disabled)
** OrderList section for displaying additional columns in order list table
** Edit section (depending on order type - here pda and digitization) sets form type (basic / complete) and possible status options
* templates
** add configured columns (like type, status, due date, edit button) on admin order list (and nested templates)
** new edit order main template (incl. some order information)
** new basic and complete form template
* add getter and setter (status, due date) on DTO order
* create updateOrderHydrator
** used for prefilling form and update order object before requesting fidis
* new translations

* add preconfigured default status on creating an order / acquisition (via trait and order hydrator)

* add template acquisition-contact-details.phtml from bbi
** used in pda action
** used in edit order action

* add translation for order type

* always show current status of order in order list
** by force reload user data inclusive orders in controller action

* allow null value on setting order status