* do not extend obsolete vufind factory - now plugin

* usage of rules evaluator and GetItRules.yaml in instance
* add temp check with old implementation - TODO: remove with 22011

* fix status on invalid session state, also refs #22043
** throw UserNotAuthorizedException on 401
** on 401 logout in RecordController homeAction

* copied nearly complete functionality introduced to adlr in ticket 16184 to fid branch
* adapt admins form for editing users
* set deleted flag to false on user registration (as default)
* show deleted info in admin user view
* configurable
* switch auth error message order
** dispay deleted account message before check on blocked account
** accounts can be blocked without flagging for removal

* adding abstract translation
* add default translation for homepage, volume and year
* build translation key within template

* EZB-Resolver:
** save access state to each ezb resolver result
** reuse getElectronicResults removed in ticket 20764
* ResolverLinks helper hands over print- or electronic results to templates instead of prepared access and message information
* handle access (article order button) and messaging in templates now
** messages are generated by type (electronic / print and access state)
* improve array merging in template resolverLinks-print.phtml

* change parseLinks method: differs from inherited finc ezb resolver by not requesting print state 10

* allowing empty comments on pda/print
* building type translation keys with _ instead of -
* fix method signature for isValid() to fit interface - can not change param of simple type mixed to string
* do not show user name in users order list
* create order edit form only if order type has form configuration in fid.ini

* occurred while fid refactoring - fix code style (see ticket 21064)
* https://projekte.ub.uni-leipzig.de/projects/vufind-projekte/repository/vufind/revisions/f7bc6bc1159582b420b211c0f4a2427fce205f28/diff/module/fid/src/Controller/CustomTraits/FidAcquisitionTrait.php

refs #20655 [fid] create some separate column field templates and split column configuration for user and admin order list

* due date
* edit

* use OrderList->displayCols array in fid.ini for activation and ordering columns
* configuration is uses for order listing in user and admin view
* restructure templating for best re-usage and less code
* move templates into fid/order directory
* add missing section in fid.ini
* using renderInContext to retain parent's template variables too
* hide empty lines / entries in renderArray-helper for displaying properties of free digitization-on-demand

* introduced translation domain for GetItBox
* refactored templates to use GetItBox domain
* refactored state logic in resolverLinks-button.phtml to work with standardized VuFind access states
* refactored and aligned GetResolverLinks->handleRequest with finc version
* remove fetchLinks from EZB, use parent

* devops info:
** run "./install-codestylechecker.sh install" to install dependencies for git hooks code style checks
** see https://projekte.ub.uni-leipzig.de/projects/finc-intern/wiki/Code-Quality-Checking_mit_PHPStorm#section-5 for integration of CS Fixer validation in PHPStorm
* $HOME/bin/codestylechecker/php-cs-fixer3 fix --config=$HOME/bin/codestylechecker/vufind.php-cs-fixer.php_cs module/fid/src/
* add missing class and method comments
* move view helper classes to correct directory
* run codesniffer-beautifier for modules and templates

co-authored by: Dorian Merz <merz@ub.uni-leipzig.de>
co-authored by: Alexander Purr <purr@ub.uni-leipzig.de>

refs #21063 [fid] changes after using PHP CS Fixer 3.1.0 instead of 2.14.0 (friendsofphp/php-cs-fixer)

* PHP CS Fixer 3.1.0 is used in VuFind8
* working just with test/vufind.php-cs-fixer.php ruleset from VuFind8
** with updated ruleset
** some rule names / settings changed because of fixer version
* running by command:
** ../VuFind8/vendor/bin/php-cs-fixer fix --config=../VuFind8/tests/vufind.php-cs-fixer.php module/fid

* vendor/bin/phpcbf --standard=tests/phpcs.xml module/fid/
* vendor/bin/php-cs-fixer fix --config=tests/vufind.php_cs module/fid
* using PHP_CodeSniffer 3.6.2 instead of 3.4.0 (squizlabs/php_codesniffer)

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* check if order has solr record / record driver
* if not: display record information given by user
* add default status on digitization without solr record

* change visibility of helper functions
* allow for ALL keyword in sources list

* new Client methods:
** get order (uses fidis GET resource)
** update order (is complemented by fidis PUT resource - ticket 20690)
* add new route for EditOrder
* new UserController methods
** editOrderAction -> loads order, form-config & view; checks EditOrder-Permission
** updateOrder
** applyStatusOptions for correct prefilling and translate of status options
* new form-configs for simple (only status) and complete (status and due date) form
* new configuration blocks in fid.ini (disabled)
** OrderList section for displaying additional columns in order list table
** Edit section (depending on order type - here pda and digitization) sets form type (basic / complete) and possible status options
* templates
** add configured columns (like type, status, due date, edit button) on admin order list (and nested templates)
** new edit order main template (incl. some order information)
** new basic and complete form template
* add getter and setter (status, due date) on DTO order
* create updateOrderHydrator
** used for prefilling form and update order object before requesting fidis
* new translations

* add preconfigured default status on creating an order / acquisition (via trait and order hydrator)

* add template acquisition-contact-details.phtml from bbi
** used in pda action
** used in edit order action

* add translation for order type

* always show current status of order in order list
** by force reload user data inclusive orders in controller action

* allow null value on setting order status

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* enable comment field for pda
** in controller
** in hydrator
* check complete address

* allow multi-step form by saving and retrieving followup url
* prevent hiding pda form in lightbox after redirect from profile update - SuccessMessage of flash messenger would disable displaying pda form

* add action in User Controller
* add form for password confirmation
* check credentials in Client
* add properties in User dto for deletion
* check for deleted property on login in Authenticator
* add default translation texts
* add template for success message
* redirect to home page after closing of modal

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* new inputs: library, signature, external_url
* now 2 different forms:
** a) via record, prefilled (like before)
** b) via profile: free request (not indexed record)
* about b)
** new action and route
** inherit and extend form configuration (new hydrator, 4 more fields) from a)
** reuse template from a) and add record-inputs
** new inputs: title (required), responsible, year, language
** record information ships via digitization-array (see FidAcquisitionTrait.php) into order object
** using createViewModel-function from AbstractBase for prevent loading not existing record
* adjust orders listing template for displaying none indexed records correctly

refs #20106 [fid] orders list
* enable external links coming from data-lightbox
* show additional request data if request is not linked to solr record

Gregor Gawol authored 3 years ago and Dorian Merz committed 3 years ago

* set default value noticeLinkType
* remove useless variable noticeWithLink

* fix problems with unset homeLibrary

* from now on, if a set of fidis permissions is configured,
  users having ANY of those will be granted the respective VuFind permission
* potentially BREAKING CHANGE

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* set additional view context parameter

* avoid unnecessary entries in electronic

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* set method get newsletter bool

* new route via "/Record/0-123456/fidDigitization"
* new form config
* new form template
* add type specific order information on acquisition trait and order hydrator
* add translation keys - incomplete jet
* add translation

* can now produce objects from sub class of fid's MyResearchController

* moves some standard configuration from ADLR module to FID module to be reused in other FIDs

* defines some basic functional permissions
* uses permission manager to give/deny access to
** acquisitions
** ebook links
* handle fid.Acqusitions permission via Permission Controller Plugin of VuFind

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* using reload flag within user details request to force refresh
* do not save order list in session any more

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* fixed bug
* remove partcopy button
* changed text

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* prevents from displaying not updated user data in VuFind
* user-object is refreshed automatically after successful user update

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* prevent notices when publication details are empty
* prevent fidis notice / error when issn in getPublishedIn is null
** set array with empty string instead