Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* enable comment field for pda
** in controller
** in hydrator
* check complete address

* allow multi-step form by saving and retrieving followup url
* prevent hiding pda form in lightbox after redirect from profile update - SuccessMessage of flash messenger would disable displaying pda form

* use getTOC and specific data template for TOC tab

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* beautify bootstrap-accessibility-en.min.js and bootstrap-accessibility-de.min.js
* override bootstrap show / hide / addAriaAndCollapsedClass: don't add aria-expanded to collapsing element
** copy methods from bootstrap.min.js and avoid setting of aria-expanded="false" or aria-expanded="true" for elements to collapse (e.g. ul)
* Recommend SideFacets: add aria-expanded for collapse trigger buttons in templates on page load

Dorian Merz authored 3 years ago and André Lahmann committed 3 years ago

* use static variable for short term caching

* but catching of error still  needs to be optimized

* removes redundant aria-labels

* removes redundant aria-hidden in footer finc link

* avoid loading spinner

* also set input division (fakultät) required in dds-form.php

Gregor Gawol authored 3 years ago and Dorian Merz committed 3 years ago

* invisible comboboxes required false

Gregor Gawol authored 4 years ago and Dorian Merz committed 3 years ago

for details see issue/19158

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* get multiple lines
* show additional data (f) for Marc license information
* combine text a (note f) with url u as link in data-license.phtml
* use external links for licenses
* move template from Default to new SolrMarc directory
* consolidate data-license of Marc and DiCo to avoid confusion with Marc data-license and digital collections introduced with #14583
** rename getLicenceInfo to getLicense in SolrDico record driver
** add Dico data-licence.phtml (moved from de_15)
** use same labels like Dico - possible to use same template under DefaultRecord

* set label sr-only

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* also delete obsolete sample configuration from config.ini
* fix and update test for ExternalCatalogueLink
** use record_id instead of ppn
** fix mocking expactations
** use test by calling: docker exec -it [your_favorite_vufind_folder]_php_1 sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/View/Helper/Root/ExternalCatalogueLinkTest.php"

Dorian Merz authored 3 years ago and André Lahmann committed 3 years ago

* streamlines with result list title

* add action in User Controller
* add form for password confirmation
* check credentials in Client
* add properties in User dto for deletion
* check for deleted property on login in Authenticator
* add default translation texts
* add template for success message
* redirect to home page after closing of modal

* do not show tab for single-element trees

* do not set refreshOnClose to true in lightbox after neccessary catalog login for saving a record as favorite
** set userIsLoggedIn to true
** hide login link
** show logout link
* improve code styles
* also anticipate jshint for 17984 to set back focus on origin after closing
* control overriding of page reload by extra parameter in template link

* usage after changing translations via i18n controller /Admin/I18n: "devops/i18n-merge.sh data/i18n/languages/de.ini local/languages/de.ini"
* add minified local/languages/de.ini
* corrects German typo for errorcode_member_not_found in local

* output:
** remove duplicate token "Email " with obsolete value  "E-Mail" by  "Mailen".
** remove duplicate token "Print " with obsolete value  Druck by  "Drucken".
** remove duplicate token "bookbag_email_selected " with obsolete value  "E-Mail" by  "Links zu ausgewählten Medien per E-Mail versenden".
** remove duplicate token "Skip_navigation_links " with obsolete value  "Sprunglinks zum Inhalt" by  "Sprunglinks zur Suche und zum Inhalt".
** replace token "errorcode_member_not_found " with old value  "Die Benutzernummer exisitiert nicht" by new value  "Der aufgerufene Titel (%%id%%) ist nicht vorhanden."

* minify local en.ini
* usage "devops/i18n-merge.sh data/i18n/languages/en.ini local/languages/en.ini"
** remove duplicate token "DBIS " with obsolete value  DBIS by  DBIS.
** remove duplicate token "Skip_navigation_links " with obsolete value  "Skip navigation links" by  "Skip navigation links".

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* new inputs: library, signature, external_url
* now 2 different forms:
** a) via record, prefilled (like before)
** b) via profile: free request (not indexed record)
* about b)
** new action and route
** inherit and extend form configuration (new hydrator, 4 more fields) from a)
** reuse template from a) and add record-inputs
** new inputs: title (required), responsible, year, language
** record information ships via digitization-array (see FidAcquisitionTrait.php) into order object
** using createViewModel-function from AbstractBase for prevent loading not existing record
* adjust orders listing template for displaying none indexed records correctly

refs #20106 [fid] orders list
* enable external links coming from data-lightbox
* show additional request data if request is not linked to solr record

* adds delegator for SolrMarcFinc
* can add SolrMarcUrlRules.yaml now
* decide on sub-result sets to be used in actual result of getURLs

* set non-lucene-syntax handling configurable on a per-SearchType basis

co-authored by: André Lahmann <lahmann@ub.uni-leipzig.de>
* added some more comments to searches.ini

Claas Kazzer authored 3 years ago and Dorian Merz committed 3 years ago

* changes overcomplex wording in carousel J

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* allow list of ids and load results as batch from solr
* escape colons centralized in getFincId
* code styles
* move searchRelatedRecords from SolrMarcFincTrait to new finc\Controller\CustomTraits\SearchTrait
* call searchRelatedRecords instead of getFincId within getAlternativeItemId
* merge elements of getFincId into getAlternativeItemId
** handle multiple ids within getAlternativeItemId
** escape colon when existing
** rude exception catching
* replace call of getFincId by getAlternativeItemId within mapPaiaItems

co-authored by "Dorian Merz <merz@ub.uni-leipzig.de>"
* slight refactoring
* add more method comments

co-authored by "André Lahmann <lahmann@ub.uni-leipzig.de>"
* added comment for choice of trait location

* copy from DE-15 code to finc's FincLibero
* use separate queryBoundItem()
* use generic pattern
* make bound item query adaptable

* isTitleHold
* placeTitleHold
* extendPickUpLocation