* also add id for valid label mapping

* adds readout of state 10
* also adds some refactoring to streamline Ezb Class

refs #18611 [finc] adds getDOI to MARC driver

refs #18611 [finc] add DOI-Parameter do Ezb-Query

+ slight refactoring

* adds readout of state 10
* also adds some refactoring to streamline Ezb Class

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* handle warning in SolrMarcFincTrait for empty indicator
* add tests and fixtures for #20600 and #18915
* run with: docker exec -it [your php container] sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/RecordDriver/SolrMarcFincTestCase.php"

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* disable admin menu for i18n
* i18n load current locale / language only

* react on empty subresult

* department as required field
* branch issue/19158_a

* added at ticket 19370
* was removed erroneously in ticket 19603

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* enable comment field for pda
** in controller
** in hydrator
* check complete address

* allow multi-step form by saving and retrieving followup url
* prevent hiding pda form in lightbox after redirect from profile update - SuccessMessage of flash messenger would disable displaying pda form

* use getTOC and specific data template for TOC tab

Dorian Merz authored 3 years ago and André Lahmann committed 3 years ago

* use static variable for short term caching

* but catching of error still  needs to be optimized

* also set input division (fakultät) required in dds-form.php

Gregor Gawol authored 3 years ago and Dorian Merz committed 3 years ago

* invisible comboboxes required false

Gregor Gawol authored 4 years ago and Dorian Merz committed 3 years ago

for details see issue/19158

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* get multiple lines
* show additional data (f) for Marc license information
* combine text a (note f) with url u as link in data-license.phtml
* use external links for licenses
* move template from Default to new SolrMarc directory
* consolidate data-license of Marc and DiCo to avoid confusion with Marc data-license and digital collections introduced with #14583
** rename getLicenceInfo to getLicense in SolrDico record driver
** add Dico data-licence.phtml (moved from de_15)
** use same labels like Dico - possible to use same template under DefaultRecord

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* also delete obsolete sample configuration from config.ini
* fix and update test for ExternalCatalogueLink
** use record_id instead of ppn
** fix mocking expactations
** use test by calling: docker exec -it [your_favorite_vufind_folder]_php_1 sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/View/Helper/Root/ExternalCatalogueLinkTest.php"

* add action in User Controller
* add form for password confirmation
* check credentials in Client
* add properties in User dto for deletion
* check for deleted property on login in Authenticator
* add default translation texts
* add template for success message
* redirect to home page after closing of modal

* do not show tab for single-element trees

Alexander Purr authored 3 years ago and Dorian Merz committed 3 years ago

* new inputs: library, signature, external_url
* now 2 different forms:
** a) via record, prefilled (like before)
** b) via profile: free request (not indexed record)
* about b)
** new action and route
** inherit and extend form configuration (new hydrator, 4 more fields) from a)
** reuse template from a) and add record-inputs
** new inputs: title (required), responsible, year, language
** record information ships via digitization-array (see FidAcquisitionTrait.php) into order object
** using createViewModel-function from AbstractBase for prevent loading not existing record
* adjust orders listing template for displaying none indexed records correctly

refs #20106 [fid] orders list
* enable external links coming from data-lightbox
* show additional request data if request is not linked to solr record

* adds delegator for SolrMarcFinc
* can add SolrMarcUrlRules.yaml now
* decide on sub-result sets to be used in actual result of getURLs

* set non-lucene-syntax handling configurable on a per-SearchType basis

co-authored by: André Lahmann <lahmann@ub.uni-leipzig.de>
* added some more comments to searches.ini

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* allow list of ids and load results as batch from solr
* escape colons centralized in getFincId
* code styles
* move searchRelatedRecords from SolrMarcFincTrait to new finc\Controller\CustomTraits\SearchTrait
* call searchRelatedRecords instead of getFincId within getAlternativeItemId
* merge elements of getFincId into getAlternativeItemId
** handle multiple ids within getAlternativeItemId
** escape colon when existing
** rude exception catching
* replace call of getFincId by getAlternativeItemId within mapPaiaItems

co-authored by "Dorian Merz <merz@ub.uni-leipzig.de>"
* slight refactoring
* add more method comments

co-authored by "André Lahmann <lahmann@ub.uni-leipzig.de>"
* added comment for choice of trait location

* copy from DE-15 code to finc's FincLibero
* use separate queryBoundItem()
* use generic pattern
* make bound item query adaptable

* isTitleHold
* placeTitleHold
* extendPickUpLocation

* now named LiberoWachtl
* less misleading naming
* refactor liberoWachtlUrl INI key
** plus: cache in local property

Gregor Gawol authored 3 years ago and Dorian Merz committed 3 years ago

* set default value noticeLinkType
* remove useless variable noticeWithLink

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* extend AbstractAdmin to check for access permission for AdminModule
** admin module must be activated in config.ini by admin_enabled = true
** permission access.AdminModule should be set in permissions.ini

* more specific message for RecordMissing exception
* redirect message in case a fallback is used

* do not check for existence of linked record on every call
* add fallback seacrh in case of calling a missing record

* remove unused getJournalHoldingsSolr in SolrMarcFincTrait
* code styles for FincIls

* adds sysMessage to success message when placing a hold
* cf. #7730

Robert Lange authored 3 years ago and Dorian Merz committed 3 years ago

* multiple pickup locations should be possible and not overwritten
* but a fallback of department as pickup location should only be set, when
** there has been a service of presentation or loan
** and no pickup location could be filtered

* fix problems with unset homeLibrary

* own array field status