Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* prevent notices when publication details are empty
* prevent fidis notice / error when issn in getPublishedIn is null
** set array with empty string instead

* add constants
* more generic order process including functions for extending within instances
* remove unused variable subitoPartialCopy

ha848myco authored 4 years ago and Dorian Merz committed 4 years ago

* Use tag p instead of div for flashmessages
* Change tag <div> with <p> for alerts
* Review class text-success
** Change <div> with <p>
** Remove margin-bottom
* move newly added files to throwaway theme
* introduce finc specific Flashmessages ViewHelper

co-authored by: "Dorian Merz <merz@ub.uni-leipzig.de>"

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

refs #18482 [finc] add missing import for ForbiddenException and ListPermissionException used in MyListAction

* if not show error template
* add error translation

* reads MARC 024
* specifies type of identifier
* also defines MultiLine RecordDataFormatterSpecs for other identifiers

* only apply for print

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* remove summary (solr:description) from
** default core
** marc core
** ai core
* add new translation for Abstract and use it in RecordDataFormatterFactory

* this is basically a backport of the new ajaxCovers Feature in VuFind 7
** see https://github.com/vufind-org/vufind/pull/1679 for details
* use recordIcon as coverReplacement
* link ajax loaded covers (de_15)
* show cover images on click (for de_15)

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* new recordriver method
* translations

* removes templates for simple escaped and translated data, this can be achieved via options in simple SpecLine
* add alterable separator to authors template
* replace data-dateSpan with RecordHelper SpecLine

André Lahmann authored 4 years ago and Dorian Merz committed 4 years ago

* add additional check for title in getSetMultipart

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

refs #18227 [finc] adding BK notation for displaying on record details via RecordDataFormatterFactory
* adjust marc driver method
* add templates (copied and improved from fid_bbi)
* add label translation

* remove bk notation search link, because search type and solr field missing

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* from fid_adlr

Dorian Merz authored 4 years ago and André Lahmann committed 4 years ago

This reverts commit 4e25eb88.

Dorian Merz authored 4 years ago and André Lahmann committed 4 years ago

* use finc-specific generalized factory

* move function to master branch

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* not cutting tailing "-7" any more
* match endings like "X", "-X" or "-2"

* remove unnecessary (and error prone) function
* bugfix in data-titleUniform: avoids undefined index error

* can now apply more than one type of pre munge
* works for other query handlers now
* TODO: adapt running instances

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* change searchspecs.yaml in local
* testing: update cross-check fixtures for finc.SearchSpecsReaderTest:testParentYaml
** local searchspec
** local alpha searchspec

* "unpacks" AjaxHandler response
* now shows item counts in MyResearch menu correctly

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* repair outdated option test in PAIATest testgetOptionsNotOnlyFirstButAll

* fixes function call bug from getItemStatus

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* prepare testing directory structure for yaml comparism
** add fixtures in same order as config files
** use symlinks for real configs
** use result searchspecs for old outcome before refactoring
* fix finc test setup for docker
* add finc SearchSpecsReaderTest
** run: docker exec -it [php container] sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/Config/SearchSpecsReaderTest.php"
[--filter testParentYaml]"

* in local searchspecs.yaml
** use vufind as parent and keep only delta
* in local alpha searchspecs.yaml
** use local as parent, no delta

* use autoconfig version 2.3.3, see also https://git.sc.uni-leipzig.de/ubl/bdd_dev/webmasterei/autoconfig/-/commit/7b396da68c63820c869d45ca655d70d77b417aef
* add env var for local searchspecs.yaml in docker-env.0.finc.yml

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* dont reload favorites because we use ajax in templates for single items
** early return when layout is lightbox
** for multiple items we still use bulk action in CartController
* dont set flash messages when deleting items
** override method performDeleteFavorite from vufind
** prevent delayed success messages when loading modals
** use VuFind.lightbox.alert with javascript in template instead (see 17711)