Skip to content
Snippets Groups Projects
  1. Apr 28, 2022
  2. Apr 27, 2022
  3. Apr 20, 2022
    • Robert Lange's avatar
      refs #20357 [finc] set punctuation for Marc titleDetails if not already set · 401d1fdc
      Robert Lange authored
      * with syntax "245a: 245b (245n); 245p/ 245c"
      * colon only when 245a AND 245b exist
      * change order of subfields for records without pre-formated punctuation and ignore 245h
      * fetch multiple subfields for 245n and 245p and concatenate with coma
      * add tests for Marc getTitleDetails punctuation
      * run with command: docker exec -it [your_docker_php_container] sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/RecordDriver/SolrMarcFincTestCase.php --filter testGetTitleDetails"
      401d1fdc
  4. Apr 01, 2022
    • Robert Lange's avatar
      refs #21133 [finc] use RecordDataFormatter for topics and rvk · 778cf4ee
      Robert Lange authored
      * add specs for topics and rvk in RecordDataFormatterFactory
      * add data-topics.phtml and data-rvk.phtml
      * use specs and render output of RecordDataFormatter in topics.phtml
      * remove obsolete message 'Topics unavailable' for empty content - tab should not be used at all due to hasTopics check
      2 tags
      778cf4ee
  5. Mar 31, 2022
    • Alexander Purr's avatar
      refs #21408 [fid] EZB resolver improvements · 5f03ae0c
      Alexander Purr authored
      * EZB-Resolver:
      ** save access state to each ezb resolver result
      ** reuse getElectronicResults removed in ticket 20764
      * ResolverLinks helper hands over print- or electronic results to templates instead of prepared access and message information
      * handle access (article order button) and messaging in templates now
      ** messages are generated by type (electronic / print and access state)
      * improve array merging in template resolverLinks-print.phtml
      
      * change parseLinks method: differs from inherited finc ezb resolver by not requesting print state 10
      5f03ae0c
    • Alexander Purr's avatar
      refs #21408 [finc] move state mapping arrays into member variables to use as default · 5f728a79
      Alexander Purr authored
      * allows manipulating on inheriting classes
      5f728a79
  6. Mar 09, 2022
    • Alexander Purr's avatar
      refs #20650 [fid] refactor order and order view · 07a20c94
      Alexander Purr authored
      * allowing empty comments on pda/print
      * building type translation keys with _ instead of -
      * fix method signature for isValid() to fit interface - can not change param of simple type mixed to string
      * do not show user name in users order list
      * create order edit form only if order type has form configuration in fid.ini
      07a20c94
  7. Mar 07, 2022
  8. Mar 02, 2022
  9. Mar 01, 2022
  10. Feb 24, 2022
  11. Feb 21, 2022
    • Robert Lange's avatar
      refs #21313 [finc] consolidate count items in menu · 556a1072
      Robert Lange authored
      * GetAdditionalAccountInfo:
      ** dont fetch fines - sum up is already done by account_ajax
      ** use GET instead of POST request
      * account_ajax: add finc override and itemCount; remove tooltips / titles
      * remove obsolete script in menu.phtml
      556a1072
  12. Feb 07, 2022
  13. Feb 03, 2022
  14. Feb 02, 2022
  15. Jan 31, 2022
  16. Jan 27, 2022
  17. Jan 26, 2022
  18. Jan 13, 2022
  19. Jan 07, 2022
  20. Jan 06, 2022
    • Robert Lange's avatar
      refs #21044 [finc] adapt icon mapping by configuration · 4c502ed1
      Robert Lange authored
      * more robust constructor of record view helper
      * code styles
      * use beautifier: "vendor/bin/phpcbf --standard=devops/codecheck/rules/phpcs.xml module/finc/src/finc/View/Helper/Root/Record.php"
      4c502ed1
    • André Lahmann's avatar
      refs #20764 [fid] refactoring of EZB resolver driver · d5f0419a
      André Lahmann authored
      * introduced translation domain for GetItBox
      * refactored templates to use GetItBox domain
      * refactored state logic in resolverLinks-button.phtml to work with standardized VuFind access states
      * refactored and aligned GetResolverLinks->handleRequest with finc version
      * remove fetchLinks from EZB, use parent
      d5f0419a
    • André Lahmann's avatar
      refs #20764 [finc] refactoring of EZB resolver driver · 84460898
      André Lahmann authored
      * add EZB resolver driver trait in finc for easier mergin and preparation of pull request
      * added resolver configuration parameters and comments to local/Resolver.ini
      * added new configuration parameters to Resolver.ini for setting ezb/zdb=1
      * aligned finc EZB resolver with VuFind EZB resolver
      * minor changes in GetResolverLinks->handleRequest to align with VuFind module
      * remove ResoverTrait and minify fetchLinks
      * inherit title selector for resolver result xpath from vufind
      
      co-authored by: Robert Lange <robert.lange@uni-leipzig.de>
      84460898
    • André Lahmann's avatar
      refs #20764 [finc] add EZB resolver driver trait in finc for easier mergin and... · 20ace5a8
      André Lahmann authored
      refs #20764 [finc] add EZB resolver driver trait in finc for easier mergin and preparation of pull request
      
      * make title selector a static variable that can be overwritten
      * add electronic result type 10 for Unknown Electronic
      * format rft.date and map rft properties
      
      co-authored by: Robert Lange <robert.lange@uni-leipzig.de>
      20ace5a8
  21. Jan 05, 2022
  22. Jan 04, 2022
  23. Dec 16, 2021
  24. Dec 15, 2021
    • Alexander Purr's avatar
      refs #21063 [fid] changes after using PHP CS Fixer 3.1.0 instead of 2.14.0... · d51e616d
      Alexander Purr authored
      refs #21063 [fid] changes after using PHP CS Fixer 3.1.0 instead of 2.14.0 (friendsofphp/php-cs-fixer)
      
      * PHP CS Fixer 3.1.0 is used in VuFind8
      * working just with test/vufind.php-cs-fixer.php ruleset from VuFind8
      ** with updated ruleset
      ** some rule names / settings changed because of fixer version
      * running by command:
      ** ../VuFind8/vendor/bin/php-cs-fixer fix --config=../VuFind8/tests/vufind.php-cs-fixer.php module/fid
      d51e616d
    • Alexander Purr's avatar
      refs #21063 [fid] running fixer · ea8e05d8
      Alexander Purr authored
      * vendor/bin/phpcbf --standard=tests/phpcs.xml module/fid/
      * vendor/bin/php-cs-fixer fix --config=tests/vufind.php_cs module/fid
      * using PHP_CodeSniffer 3.6.2 instead of 3.4.0 (squizlabs/php_codesniffer)
      ea8e05d8
  25. Dec 08, 2021
    • Robert Lange's avatar
      refs #19208_merge [finc] map icons by config · 18169b70
      Robert Lange authored
      * configure style based icons in separate config file iconMapping.ini
      * specify mapping by type and set defaults for finc (transfered and simplified from record-icon-class.phtml)
      * fetch single or multiple facets in recordViewHelper and merge them - specified by type and concatenateKeys
      * remove obsolete templates record-icon-class.phtml, record-icon-class, record-icon-sprite, and record-icon-sprite-class
      * map icons by facetAvail (default)
      * add mapping by format (alternative)
      * add additional translations
      * use lowercase for format icon mapping
  26. Dec 07, 2021
  27. Dec 03, 2021
  28. Nov 29, 2021
  29. Nov 24, 2021
    • Robert Lange's avatar
      refs #20842 [finc] refactor getPickUpLocations · 70bdeee5
      Robert Lange authored
      * move getWachtlPickUpLocations from de_zwi2, de_d13 to LiberoWachtlTrait for PAIA usage to fetch pickUpLocations
      * move getPickUpLocations from de_105, de_l152, de_15, de_ch1 to FincLibero for DAIA usage to fetch pickUpLocations
      ** check for config var "useWachtlPickupLocations" to use LiberoWachtlTrait
      ** check for useDaiaLocationId to use FincIls getPickUpLocations
      ** otherwise use customData from getCustomData
      
      * refactor parseDaiaArray for getPickUpLocations
      ** set item_id for non-title-hold orders (storage retrieval request)
      ** also refs #20223
      70bdeee5