Removed unused variables.

module/VuFind/src/VuFind/Config/Upgrade.php

@@ -1139,7 +1139,6 @@ class Upgrade
     protected function upgradePrimoServerSettings()
     {
         $config = & $this->newConfigs['Primo.ini'];
-        $permissions = & $this->newConfigs['permissions.ini'];
         // Convert apiId to url
         if (isset($config['General']['apiId'])) {
             $url = 'http://' . $config['General']['apiId']

module/VuFind/src/VuFind/ILS/Driver/XCNCIP2.php

@@ -1334,7 +1334,7 @@ class XCNCIP2 extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterf
         $response = [];
 
         foreach ($details as $cancelDetails) {
-            list($itemAgencyId, $requestId, $bibId) = explode("|", $cancelDetails);
+            list($itemAgencyId, $requestId) = explode("|", $cancelDetails);
             $request = $this->getCancelRequest(
                 $username, $password, $patronAgency,
                 $itemAgencyId, $requestId, "Hold"
@@ -1406,7 +1406,7 @@ class XCNCIP2 extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterf
         $response = [];
 
         foreach ($details as $cancelDetails) {
-            list($itemAgencyId, $requestId, $bibId) = explode("|", $cancelDetails);
+            list($itemAgencyId, $requestId) = explode("|", $cancelDetails);
             $request = $this->getCancelRequest(
                 $username,
                 $password,
@@ -1474,7 +1474,7 @@ class XCNCIP2 extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterf
     {
         $details = [];
         foreach ($renewDetails['details'] as $agencyId_renewId) {
-            list($agencyId, $renewId, $bibId) = explode("|", $agencyId_renewId);
+            list($agencyId, $renewId) = explode("|", $agencyId_renewId);
             $request = $this->getRenewRequest(
                 $renewDetails['patron']['cat_username'],
                 $renewDetails['patron']['cat_password'], $renewId,

module/VuFind/src/VuFind/Search/Base/Params.php

@@ -1094,7 +1094,7 @@ class Params implements ServiceLocatorAwareInterface
         // Build up an array of checkbox facets with status booleans and
         // toggle URLs.
         $result = [];
-        foreach ($this->checkboxFacets as $field => $facets) {
+        foreach ($this->checkboxFacets as $facets) {
             foreach ($facets as $facet) {
                 $facet['selected'] = $this->hasFilter($facet['filter']);
                 // Is this checkbox always visible, even if non-selected on the

module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php

@@ -313,7 +313,6 @@ class SearchTabs extends \Zend\View\Helper\AbstractHelper
         // If an advanced search is available, link there; otherwise, just go
         // to the search home:
         $results = $this->results->get($class);
-        $urlParams = $results->getUrlQuery()->getParams(false);
         $url = $this->url->__invoke($results->getOptions()->getSearchHomeAction())
             . $this->buildUrlHiddenFilters($results, $filters);
         return [