From a933d627906a2034f940431829d1a909231787e6 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Thu, 14 Apr 2016 09:56:40 -0400
Subject: [PATCH] Removed unused variables.
---
module/VuFind/src/VuFind/Config/Upgrade.php | 1 -
module/VuFind/src/VuFind/ILS/Driver/XCNCIP2.php | 6 +++---
module/VuFind/src/VuFind/Search/Base/Params.php | 2 +-
module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php | 1 -
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/module/VuFind/src/VuFind/Config/Upgrade.php b/module/VuFind/src/VuFind/Config/Upgrade.php
index 1a4e4397e84..d5a65bb26cf 100644
--- a/module/VuFind/src/VuFind/Config/Upgrade.php
+++ b/module/VuFind/src/VuFind/Config/Upgrade.php
@@ -1139,7 +1139,6 @@ class Upgrade
protected function upgradePrimoServerSettings()
{
$config = & $this->newConfigs['Primo.ini'];
- $permissions = & $this->newConfigs['permissions.ini'];
// Convert apiId to url
if (isset($config['General']['apiId'])) {
$url = 'http://' . $config['General']['apiId']
diff --git a/module/VuFind/src/VuFind/ILS/Driver/XCNCIP2.php b/module/VuFind/src/VuFind/ILS/Driver/XCNCIP2.php
index ad82f9983a9..787e4382b31 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/XCNCIP2.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/XCNCIP2.php
@@ -1334,7 +1334,7 @@ class XCNCIP2 extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterf
$response = [];
foreach ($details as $cancelDetails) {
- list($itemAgencyId, $requestId, $bibId) = explode("|", $cancelDetails);
+ list($itemAgencyId, $requestId) = explode("|", $cancelDetails);
$request = $this->getCancelRequest(
$username, $password, $patronAgency,
$itemAgencyId, $requestId, "Hold"
@@ -1406,7 +1406,7 @@ class XCNCIP2 extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterf
$response = [];
foreach ($details as $cancelDetails) {
- list($itemAgencyId, $requestId, $bibId) = explode("|", $cancelDetails);
+ list($itemAgencyId, $requestId) = explode("|", $cancelDetails);
$request = $this->getCancelRequest(
$username,
$password,
@@ -1474,7 +1474,7 @@ class XCNCIP2 extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterf
{
$details = [];
foreach ($renewDetails['details'] as $agencyId_renewId) {
- list($agencyId, $renewId, $bibId) = explode("|", $agencyId_renewId);
+ list($agencyId, $renewId) = explode("|", $agencyId_renewId);
$request = $this->getRenewRequest(
$renewDetails['patron']['cat_username'],
$renewDetails['patron']['cat_password'], $renewId,
diff --git a/module/VuFind/src/VuFind/Search/Base/Params.php b/module/VuFind/src/VuFind/Search/Base/Params.php
index f1df82a0cf7..1fb493b4761 100644
--- a/module/VuFind/src/VuFind/Search/Base/Params.php
+++ b/module/VuFind/src/VuFind/Search/Base/Params.php
@@ -1094,7 +1094,7 @@ class Params implements ServiceLocatorAwareInterface
// Build up an array of checkbox facets with status booleans and
// toggle URLs.
$result = [];
- foreach ($this->checkboxFacets as $field => $facets) {
+ foreach ($this->checkboxFacets as $facets) {
foreach ($facets as $facet) {
$facet['selected'] = $this->hasFilter($facet['filter']);
// Is this checkbox always visible, even if non-selected on the
diff --git a/module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php b/module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php
index b7d685b82d3..fc68369757d 100644
--- a/module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php
+++ b/module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php
@@ -313,7 +313,6 @@ class SearchTabs extends \Zend\View\Helper\AbstractHelper
// If an advanced search is available, link there; otherwise, just go
// to the search home:
$results = $this->results->get($class);
- $urlParams = $results->getUrlQuery()->getParams(false);
$url = $this->url->__invoke($results->getOptions()->getSearchHomeAction())
. $this->buildUrlHiddenFilters($results, $filters);
return [
--
GitLab