Skip to content
Snippets Groups Projects
  1. Oct 10, 2022
    • Robert Lange's avatar
      refs #22236 [fid_adlr] fix MissingRecords in favorite list · adbcf25a
      Robert Lange authored
      * use tryMethod for getting source id
      * move fallback search into alert box
      2 tags
      adbcf25a
    • Alexander Purr's avatar
      refs #21417 [fid_adlr] w3c validation · f089b003
      Alexander Purr authored
      * start page
      ** <meta name="description"> only once - language check
      ** remove tabindex="-1" on search button's inner span
      
      * result list
      ** Element form not allowed as child of element span in this context -> search controls sort and pages
      ** an unquoted attribute value. Probable causes: Attributes running together or a URL query string in an unquoted attribute value. -> added quote in result grouping template
      ** Element a not allowed as child of element ul in this context. (Suppressing further errors from this subtree.) -> facet-lists more / less links within li (from finc-accessibility theme)
      ** Element div not allowed as child of element ul in this context. (Suppressing further errors from this subtree.) -> date range slider facet as li (+ additional styling)
      ** The select element cannot have more than one selected option descendant unless the multiple attribute is specified. -> remove selected attribute from disabled option for limit and sort in offcanvas
      ** Attribute maxlength is only allowed when the input type is email, password, search, tel, text, or url. -> reuse finc version for date range slider (max instead of maxlength)
      
      * details view
      ** Element p not allowed as child of element h3 in this context. (Suppressing further errors from this subtree.) -> subtitle as span instead of p
      ** Duplicate ID toolbar-menu. -> remove second
      ** Element ul not allowed as child of element span in this context. (Suppressing further errors from this subtree.) -> span to div
      ** Attribute href not allowed on element button at this point. -> href to data-target
      ** Get-It-Box: #get-it-button / Ressources-Button (/Record/0-725915765)
      ** RecordTabs: #side-collapse-... (/Record/0-725915765)
      ** Bad value >>side-panel-Table of Contents<< for attribute id on element div: An ID must not contain whitespace. -> RecordTabs: use $tab instead $desc for construct ID in core-templates (but IDs are not really in use, IDs used just for styling)
      
      * result list (active filters)
      ** Duplicate ID applied_filter_1 -> in searchbox.phtml applied filter were rendered twice
      ** Attribute href not allowed on element button at this point. -> href to data-target
      ** toggle button facet group
      ** End tag ul seen, but there were open elements. -> moving endif (closing div and li was missed before); problem only if filters are active
      
      * date range slider
      ** revert design changes of ticket 22462
      ** add up & down Arrows again by using input type=number
      
      * result list advanced search
      ** No p element in scope but a p end tag seen. -> remove falsely added closing p
      
      co-authored by: Robert Lange <robert.lange@uni-leipzig.de>
      * add missing closing div in view
      2 tags
      f089b003
    • Robert Lange's avatar
      c81a9f29
    • Robert Lange's avatar
      Merge branch 'finc' into instance/fid · e79b3a93
      Robert Lange authored
      e79b3a93
  2. Oct 05, 2022
  3. Sep 27, 2022
  4. Sep 22, 2022
  5. Sep 21, 2022
  6. Sep 20, 2022
    • Robert Lange's avatar
      refs #22022 [finc] prepare tests for citavi export · df644f6e
      Robert Lange authored
      * add test for getPages and .enw-output of marc and ai records
      * add fixures for marc and ai
      * code styles for SolrDefaultFincTrait
      * fix SolrMarcNewerPreviousTest
      * run test via: docker exec -it vufind_php_1 sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/RecordDriver"
      df644f6e
  7. Sep 19, 2022
  8. Sep 15, 2022
  9. Sep 14, 2022
  10. Sep 09, 2022
  11. Sep 08, 2022