André Lahmann authored 4 years ago and Dorian Merz committed 4 years ago

* add additional check for title in getSetMultipart

André Lahmann authored 4 years ago and Dorian Merz committed 4 years ago

* remove search tools from result list bottom

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* add marc driver function for getting performer note (marc 511 |a)
* display additional authors
** add role value to getAdditionalAuthors marc function
** add template
* add corporations / corporate authors template
* add rvk notation template

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

refs #18227 [finc] adding BK notation for displaying on record details via RecordDataFormatterFactory
* adjust marc driver method
* add templates (copied and improved from fid_bbi)
* add label translation

* remove bk notation search link, because search type and solr field missing

* use shards main and ai for alphas and in finc docker file
* set AI url

Dorian Merz authored 4 years ago and André Lahmann committed 4 years ago

This reverts commit 4e25eb88.

Claas Kazzer authored 4 years ago and André Lahmann committed 4 years ago

* adds missing labels in finc

Dorian Merz authored 4 years ago and André Lahmann committed 4 years ago

* use finc-specific generalized factory

Robert Lange authored 4 years ago and André Lahmann committed 4 years ago

* reset to original operating mode: first cover, then style based icons
** Default core
** SolrAI core
** SolrMarc core
* but if cover cannot be loaded, then use style based icon as fallback
** by using object tag with inner icon
** by setting content of fallback icon noCover2 to empty => interpreted as no content in browser

* add new fallback icon instead of changing existing

** keep noCover2.gif unchanged, but add new empty file noCoverEmpty.gif
** use noCoverEmpty.gif in finc as default noCoverAvailableImage set in config.ini
** after merging this branch, instances won't have a noCoverAvailableImage anymore:
*** either set noCoverAvailableImage = images/noCover2.gif in instance config.ini
*** or use object tag in core templates as in master core templates

co-authored by: "ckaz <kazzer@uni-leipzig.de>"
refs #17752 [finc vf5] fixes record view icon placement

* fixes record view icon placement for left-aligned facets in
** DefaultRecord/core
** SolrAi/core
** SolrMarc/core

* fixes style-based icon display with left-aligned facets
* corrects switchable ini-settings for displaying either stylebasedicons
or other icons/covers

* adds definition for right-floating record view icons when sidebar is
left-aligned

Robert Lange authored 4 years ago and André Lahmann committed 4 years ago

* add missing abort - option
* add href for focus

Claas Kazzer authored 4 years ago and André Lahmann committed 4 years ago

* re-instates cancel button that was missing since issue 17711

Claas Kazzer authored 4 years ago and André Lahmann committed 4 years ago

* fixes transparent modal bug -- must-have for all instances!!

* move function to master branch

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* removed library weimar
* changed transEsc to translate external links

Alexander Purr authored 4 years ago and Dorian Merz committed 4 years ago

* not cutting tailing "-7" any more
* match endings like "X", "-X" or "-2"

* remove unnecessary (and error prone) function
* bugfix in data-titleUniform: avoids undefined index error

* can now apply more than one type of pre munge
* works for other query handlers now
* TODO: adapt running instances

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* change searchspecs.yaml in local
* testing: update cross-check fixtures for finc.SearchSpecsReaderTest:testParentYaml
** local searchspec
** local alpha searchspec

* "unpacks" AjaxHandler response
* now shows item counts in MyResearch menu correctly

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* repair outdated option test in PAIATest testgetOptionsNotOnlyFirstButAll

* fixes function call bug from getItemStatus

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* prepare testing directory structure for yaml comparism
** add fixtures in same order as config files
** use symlinks for real configs
** use result searchspecs for old outcome before refactoring
* fix finc test setup for docker
* add finc SearchSpecsReaderTest
** run: docker exec -it [php container] sh -c "vendor/bin/phpunit --configuration module/finc/tests/phpunit.xml module/finc/tests/unit-tests/src/fincTest/Config/SearchSpecsReaderTest.php"
[--filter testParentYaml]"

* in local searchspecs.yaml
** use vufind as parent and keep only delta
* in local alpha searchspecs.yaml
** use local as parent, no delta

* use autoconfig version 2.3.3, see also https://git.sc.uni-leipzig.de/ubl/bdd_dev/webmasterei/autoconfig/-/commit/7b396da68c63820c869d45ca655d70d77b417aef
* add env var for local searchspecs.yaml in docker-env.0.finc.yml

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* dont reload favorites because we use ajax in templates for single items
** early return when layout is lightbox
** for multiple items we still use bulk action in CartController
* dont set flash messages when deleting items
** override method performDeleteFavorite from vufind
** prevent delayed success messages when loading modals
** use VuFind.lightbox.alert with javascript in template instead (see 17711)

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* give user feedback when deleting single favorite by spinner
* remove list items after successful deleting, don't reload page
* show lightbox on error or success => should replace overriden functionality of setting buggy flash messages in performDeleteFavorite

* filter out empty links

* reverts #13902
* adds MultiDataFieldsTrait to offer some multiline functions
* adapts relevant templates

Robert Lange authored 4 years ago and Dorian Merz committed 4 years ago

* introduce PAIA options containing pickupbranch
* needed to differentiate between storageId and pickuplocation of ILL items:
** read paiaConditions from FincLibero.ini
** add method 'mapOptions' to read certain or all options of PAIA conditions

for details see issue/17508

Gregor Gawol authored 4 years ago and Dorian Merz committed 4 years ago

* set link label with config
* retrieve subfield sequence y then n and then 3
* added indicators

* adapts getTOC to MARC standard