Code simplification.

module/VuFind/src/VuFind/RecordTab/Factory.php

@@ -145,13 +145,8 @@ class Factory
         // ILS driver specifies no holdings, we need to pass in a connection
         // object:
         $config = $sm->get('VuFind\Config\PluginManager')->get('config');
-        if (isset($config->Site->hideHoldingsTabWhenEmpty)
-            && $config->Site->hideHoldingsTabWhenEmpty
-        ) {
-            $catalog = $sm->get('VuFind\ILS\Connection');
-        } else {
-            $catalog = false;
-        }
+        $catalog = ($config->Site->hideHoldingsTabWhenEmpty ?? false)
+            ? $sm->get('VuFind\ILS\Connection') : null;
         return new HoldingsILS($catalog);
     }
 

module/VuFind/src/VuFind/RecordTab/HoldingsILS.php

@@ -39,9 +39,9 @@ namespace VuFind\RecordTab;
 class HoldingsILS extends AbstractBase
 {
     /**
-     * ILS connection (or false if not applicable)
+     * ILS connection (or null if not applicable)
      *
-     * @param \VuFind\ILS\Connection|bool
+     * @param \VuFind\ILS\Connection
      */
     protected $catalog;
 
@@ -49,12 +49,11 @@ class HoldingsILS extends AbstractBase
      * Constructor
      *
      * @param \VuFind\ILS\Connection|bool $catalog ILS connection to use to check
-     * for holdings before displaying the tab; set to false if no check is needed
+     * for holdings before displaying the tab; set to null if no check is needed
      */
-    public function __construct($catalog)
+    public function __construct(\VuFind\ILS\Connection $catalog = null)
     {
-        $this->catalog = ($catalog && $catalog instanceof \VuFind\ILS\Connection)
-            ? $catalog : false;
+        $this->catalog = $catalog;
     }
 
     /**