Skip to content
Snippets Groups Projects
Commit ef3c95d3 authored by Demian Katz's avatar Demian Katz
Browse files

Null coalescing.

parent 6cae3d93
No related merge requests found
...@@ -89,7 +89,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -89,7 +89,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function getConfig($function, $params = null) public function getConfig($function, $params = null)
{ {
return isset($this->config[$function]) ? $this->config[$function] : false; return $this->config[$function] ?? false;
} }
/** /**
...@@ -99,8 +99,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -99,8 +99,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
protected function getIdPrefix() protected function getIdPrefix()
{ {
return isset($this->config['settings']['idPrefix']) return $this->config['settings']['idPrefix'] ?? null;
? $this->config['settings']['idPrefix'] : null;
} }
/** /**
...@@ -131,8 +130,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -131,8 +130,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function getStatus($id) public function getStatus($id)
{ {
$useStatus = isset($this->config['settings']['useStatus']) $useStatus = $this->config['settings']['useStatus'] ?? 'none';
? $this->config['settings']['useStatus'] : 'none';
if ($useStatus == "custom") { if ($useStatus == "custom") {
$status = $this->translate($this->config['Status']['status']); $status = $this->translate($this->config['Status']['status']);
return [ return [
...@@ -173,8 +171,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -173,8 +171,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function getStatuses($idList) public function getStatuses($idList)
{ {
$useStatus = isset($this->config['settings']['useStatus']) $useStatus = $this->config['settings']['useStatus'] ?? 'none';
? $this->config['settings']['useStatus'] : 'none';
if ($useStatus == "custom" || $useStatus == "marc") { if ($useStatus == "custom" || $useStatus == "marc") {
$status = []; $status = [];
foreach ($idList as $id) { foreach ($idList as $id) {
...@@ -201,8 +198,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -201,8 +198,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function getHolding($id, array $patron = null) public function getHolding($id, array $patron = null)
{ {
$useHoldings = isset($this->config['settings']['useHoldings']) $useHoldings = $this->config['settings']['useHoldings'] ?? 'none';
? $this->config['settings']['useHoldings'] : 'none';
if ($useHoldings == "custom") { if ($useHoldings == "custom") {
return [ return [
...@@ -250,8 +246,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -250,8 +246,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
protected function getFormattedMarcDetails($recordDriver, $configSection) protected function getFormattedMarcDetails($recordDriver, $configSection)
{ {
$marcStatus = isset($this->config[$configSection]) $marcStatus = $this->config[$configSection] ?? false;
? $this->config[$configSection] : false;
if ($marcStatus) { if ($marcStatus) {
$field = $marcStatus['marcField']; $field = $marcStatus['marcField'];
unset($marcStatus['marcField']); unset($marcStatus['marcField']);
...@@ -285,8 +280,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -285,8 +280,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function hasHoldings($id) public function hasHoldings($id)
{ {
$useHoldings = isset($this->config['settings']['useHoldings']) $useHoldings = $this->config['settings']['useHoldings'] ?? '';
? $this->config['settings']['useHoldings'] : '';
// "none" will be processed differently in the config depending // "none" will be processed differently in the config depending
// on whether it's in or out of quotes; handle both cases. // on whether it's in or out of quotes; handle both cases.
...@@ -342,8 +336,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -342,8 +336,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function getOfflineMode() public function getOfflineMode()
{ {
return isset($this->config['settings']['mode']) return $this->config['settings']['mode'] ?? 'ils-offline';
? $this->config['settings']['mode'] : "ils-offline";
} }
/** /**
...@@ -355,8 +348,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface ...@@ -355,8 +348,7 @@ class NoILS extends AbstractBase implements TranslatorAwareInterface
*/ */
public function loginIsHidden() public function loginIsHidden()
{ {
return isset($this->config['settings']['hideLogin']) return $this->config['settings']['hideLogin'] ?? false;
? $this->config['settings']['hideLogin'] : false;
} }
/** /**
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment