* hotfix for displaying renew-error messages

8cfac80c · André Lahmann · d734589b · 8cfac80c
Commit 8cfac80c authored 8 years ago by André Lahmann
--- a/module/finc/src/finc/ILS/Driver/PAIA.php
+++ b/module/finc/src/finc/ILS/Driver/PAIA.php
@@ -868,26 +868,31 @@ class PAIA extends DAIA
        } else {
            $elements = $array_response['doc'];
            foreach ($elements as $element) {
-                $item_id = $element['item'];
+                // VuFind can only assign the response to an id - if none is given
-                if (array_key_exists('error', $element)) {
+                // (which is possible) simply skip this response element
-                    $details[$item_id] = [
+                if (isset($element['item'])) {
-                        'success' => false,
+                    if (isset($element['error'])) {
-                        'sysMessage' => $element['error']
+                        $details[$element['item']] = [
-                    ];
+                            'success' => false,
-                } elseif ($element['status'] == '3') {
+                            'sysMessage' => $element['error']
-                    $details[$item_id] = [
+                        ];
-                        'success'  => true,
+                    } elseif ($element['status'] == '3') {
-                        'new_date' => $element['endtime'],
+                        $details[$element['item']] = [
-                        'item_id'  => 0,
+                            'success'  => true,
-                        'sysMessage' => 'Successfully renewed'
+                            'new_date' => isset($element['endtime'])
-                    ];
+                                ? $this->convertDatetime($element['endtime']) : '',
-                } else {
+                            'item_id'  => 0,
-                    $details[$item_id] = [
+                            'sysMessage' => 'Successfully renewed'
-                        'success'  => false,
+                        ];
-                        'new_date' => $element['endtime'],
+                    } else {
-                        'item_id'  => 0,
+                        $details[$element['item']] = [
-                        'sysMessage' => 'Request rejected'
+                            'success'  => false,
-                    ];
+                            'item_id'  => 0,
+                            'new_date' => isset($element['endtime'])
+                                ? $this->convertDatetime($element['endtime']) : '',
+                            'sysMessage' => 'Request rejected'
+                        ];
+                    }
                }
                // DAIA cache cannot be cleared for particular item as PAIA only