From 8cfac80c00fde60c788b2468b527328b809565a6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Lahmann?= <lahmann@ub.uni-leipzig.de>
Date: Mon, 12 Sep 2016 14:57:53 +0200
Subject: [PATCH] * hotfix for displaying renew-error messages
---
module/finc/src/finc/ILS/Driver/PAIA.php | 45 +++++++++++++-----------
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/module/finc/src/finc/ILS/Driver/PAIA.php b/module/finc/src/finc/ILS/Driver/PAIA.php
index bfe811111bc..64114a37ceb 100644
--- a/module/finc/src/finc/ILS/Driver/PAIA.php
+++ b/module/finc/src/finc/ILS/Driver/PAIA.php
@@ -868,26 +868,31 @@ class PAIA extends DAIA
} else {
$elements = $array_response['doc'];
foreach ($elements as $element) {
- $item_id = $element['item'];
- if (array_key_exists('error', $element)) {
- $details[$item_id] = [
- 'success' => false,
- 'sysMessage' => $element['error']
- ];
- } elseif ($element['status'] == '3') {
- $details[$item_id] = [
- 'success' => true,
- 'new_date' => $element['endtime'],
- 'item_id' => 0,
- 'sysMessage' => 'Successfully renewed'
- ];
- } else {
- $details[$item_id] = [
- 'success' => false,
- 'new_date' => $element['endtime'],
- 'item_id' => 0,
- 'sysMessage' => 'Request rejected'
- ];
+ // VuFind can only assign the response to an id - if none is given
+ // (which is possible) simply skip this response element
+ if (isset($element['item'])) {
+ if (isset($element['error'])) {
+ $details[$element['item']] = [
+ 'success' => false,
+ 'sysMessage' => $element['error']
+ ];
+ } elseif ($element['status'] == '3') {
+ $details[$element['item']] = [
+ 'success' => true,
+ 'new_date' => isset($element['endtime'])
+ ? $this->convertDatetime($element['endtime']) : '',
+ 'item_id' => 0,
+ 'sysMessage' => 'Successfully renewed'
+ ];
+ } else {
+ $details[$element['item']] = [
+ 'success' => false,
+ 'item_id' => 0,
+ 'new_date' => isset($element['endtime'])
+ ? $this->convertDatetime($element['endtime']) : '',
+ 'sysMessage' => 'Request rejected'
+ ];
+ }
}
// DAIA cache cannot be cleared for particular item as PAIA only
--
GitLab