refs #20876 [fid] render links with external link view helper

themes/fid/templates/ajax/resolverLinks.phtml

@@ -12,9 +12,17 @@
             <li>
               <?php if (!empty($link['href'])): ?>
               <?php /* fid: #16136 remove traffic light - GG */?>
-                  <a href="<?=$this->escapeHtmlAttr($link['href'])?>" target="_blank" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"<?=!empty($link['access'])?' class="access-'.$link['access'].'"':''?>>
-                      <i class="icon icon-external-link" aria-hidden="true"></i><?=isset($link['title'])?$this->escapeHtml($this->transEsc($link['title'])):''?>
-                  </a> <br />
+                  <?= $this->externalLink(
+                      $this->escapeHtmlAttr($link['href']),
+                      '<i class="icon icon-external-link" aria-hidden="true"></i>'
+                        . (isset($link['title']) ? $this->escapeHtml($this->transEsc($link['title'])) : ''),
+                      [
+                          'title' => isset($link['service_type']) ? $this->escapeHtmlAttr($link['service_type']) : '',
+                          'class' => !empty($link['access']) ? 'access-' . $link['access'] : ''
+                      ],
+                      true
+                  ); ?>
+                  <br />
                   <?php /* fid: #16136 remove coverage - GG */?>
               <?php else: ?>
                 <?=isset($link['title'])?$this->escapeHtml($this->transEsc($link['title'])):''?>

themes/fid/templates/footer.phtml

@@ -37,12 +37,18 @@
       <div class="footer-column">
         <?=$this->layout()->poweredBy?>
         <span lang="en">Powered by</span>
-        <a href="https://vufind.org/" title="<?=$this->transEsc('vufind-logo_title')?>" target="_blank">
-          <img src="<?=$this->imageLink('vufind_logo.png')?>" alt="<?=$this->transEsc('vufind-logo_alt')?>"/>
-        </a>
-        <a href="http://blog.finc.info" title="<?=$this->transEsc('finc-logo_title')?>" target="_blank">
-          <img src="<?=$this->imageLink('finc_logo.png')?>" alt="<?=$this->transEsc('finc-logo_alt')?>"/>
-        </a>
+        <?= $this->externalLink(
+              "https://vufind.org",
+              '<img src="' . $this->imageLink('vufind_logo.png') . '" alt="' . $this->translate('vufind-logo_alt') . '" aria-hidden="true"/>',
+              ['title' => $this->translate('vufind-logo_title')],
+              true
+        ) ?>
+        <?= $this->externalLink(
+              "https://blog.finc.info",
+              '<img src="' . $this->imageLink('finc_logo.png') . '" alt="' . $this->translate('finc-logo_alt') . '" aria-hidden="true"/>',
+              ['title' => $this->translate('finc-logo_title')],
+              true
+        ) ?>
       </div>
     </div>
 </footer>

themes/fid/templates/myresearch/databases.phtml

@@ -37,7 +37,7 @@ $account = $this->auth()->getManager();
     <ul class="licenses">
       <?php foreach ($licenses as $license): ?>
         <li>
-          <a href="<?= $license['url'] ?>" target="_blank"><?= $this->translate('licenses_' . $license['name']) ?></a><br/>
+          <?= $this->externalLink($license['url'], $this->translate('licenses_' . $license['name'])) ?><br/>
           <span><?= $license['desc'] ?></span>
           <br/><br/>
         </li>