refs #18674 [master] citation, also display years with square brackets

* improve apa template

module/finc/src/finc/View/Helper/Root/Citation.php

@@ -502,7 +502,9 @@ class Citation extends \VuFind\View\Helper\Root\Citation
     protected function getYear()
     {
         if (isset($this->details['pubDate'])) {
-            if (strlen($this->details['pubDate']) > 4) {
+            if ((strlen($this->details['pubDate']) > 4)
+                && !preg_match("/^\[\d+\]/", $this->details['pubDate'])
+            ) {
                 try {
                     return $this->dateConverter->convertFromDisplayDate(
                         'Y',

themes/finc/templates/Citation/apa.phtml

 <?php if (!empty($this->authors)): ?><?=$this->escapeHtml($this->authors)?>
-  <?php if (!empty($this->year)): ?><?php if (!empty($this->authors)): ?><?php endif; ?>(<?=$this->escapeHtml($this->year)?>). <?php endif; ?>
+  <?php if (!empty($this->year)): ?>
+    <?php if (!preg_match("/^\[\d+\]/", $this->year)): ?>
+      (<?=$this->escapeHtml($this->year)?>).
+    <?php else: ?>
+      <?=$this->escapeHtml($this->year)?>.
+    <?php endif; ?>
+  <?php endif; ?>
 <?php endif; ?>
 <i><?=$this->escapeHtml($this->title)?></i><?php if ($this->periodAfterTitle): ?>. <?php endif ?>
 <?php if (empty($this->authors)): ?>