Skip to content
Snippets Groups Projects
Commit 2678611a authored by Alexander Purr's avatar Alexander Purr Committed by Robert Lange
Browse files

refs #23220 [finc] list-entry header

* add closing div and header to prevent broken html structure
* failure only on collections (dico records - only de_15)
* just hotfix - will be solved more elegantly with ticket 24265

* refactor summInCollection display logic
** remove FALSE from if-statement, condition was never fulfilled
** use $collId correctly
parent 616aeb27
No related merge requests found
...@@ -69,6 +69,10 @@ ...@@ -69,6 +69,10 @@
<div class="resultItemLine2"> <div class="resultItemLine2">
<?php if ($this->driver->isCollection()): ?> <?php if ($this->driver->isCollection()): ?>
<?php // finc: add closing div and header #23220 - was missing in #19396 ff.
// just hotfix - will be improved with #24265 ?>
</div>
</header>
<?=implode('<br>', array_map([$this, 'escapeHtml'], $this->driver->getSummary())); ?> <?=implode('<br>', array_map([$this, 'escapeHtml'], $this->driver->getSummary())); ?>
<?php else: ?> <?php else: ?>
<?php $summAuthors = $this->driver->getPrimaryAuthors(); <?php $summAuthors = $this->driver->getPrimaryAuthors();
...@@ -91,12 +95,14 @@ ...@@ -91,12 +95,14 @@
<?php elseif (!empty($summDate)): ?> <?php elseif (!empty($summDate)): ?>
<?=$this->transEsc('Published') . ' ' . $this->escapeHtml($summDate[0])?> <?=$this->transEsc('Published') . ' ' . $this->escapeHtml($summDate[0])?>
<?php endif; ?> <?php endif; ?>
<?php // finc: remove FALSE from if-statement, condition was never fulfilled #23220 ?>
<?php $summInCollection = $this->driver->getContainingCollections(); <?php $summInCollection = $this->driver->getContainingCollections();
if (false && !empty($summInCollection)): ?> if (!empty($summInCollection)): ?>
<?php foreach ($summInCollection as $collId => $collText): ?> <?php foreach ($summInCollection as $collId => $collText): ?>
<div> <div>
<strong><?=$this->transEsc("in_collection_label")?></strong> <strong><?=$this->transEsc("in_collection_label")?></strong>
<a class="collectionLinkText" href="<?=$this->record($this->driver)->getLink('collection', $collid)?>"> <?php // finc: use $collId correctly #23220 ?>
<a class="collectionLinkText" href="<?=$this->record($this->driver)->getLink('collection', $collId)?>">
<?=$this->escapeHtml($collText)?> <?=$this->escapeHtml($collText)?>
</a> </a>
</div> </div>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment