Skip to content
Snippets Groups Projects
Commit ff64852f authored by Demian Katz's avatar Demian Katz
Browse files

Add ability to use Selenium driver instead of Zombie.js.

- Note that as of this writing, tests only pass under Zombie.js.
parent 35769497
No related merge requests found
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
<property name="pgsqlhost" value="localhost" /> <property name="pgsqlhost" value="localhost" />
<property name="pgsqlrootuser" value="postgres" /> <property name="pgsqlrootuser" value="postgres" />
<property name="phpunit_extra_params" value="" /> <property name="phpunit_extra_params" value="" />
<property name="mink_driver" value="zombiejs" /><!-- may also be set to selenium -->
<property name="php-cs-fixers" value="no_blank_lines_before_namespaces,function_call_space,trailing_spaces,unused_use,lowercase_keywords,encoding,parenthesis,php_closing_tag,visibility,duplicate_semicolon,extra_empty_lines,no_blank_lines_after_class_opening,no_empty_lines_after_phpdocs,operators_spaces,spaces_before_semicolon,ternary_spaces,concat_with_spaces,short_array_syntax,phpdoc_no_access,remove_leading_slash_use" /> <property name="php-cs-fixers" value="no_blank_lines_before_namespaces,function_call_space,trailing_spaces,unused_use,lowercase_keywords,encoding,parenthesis,php_closing_tag,visibility,duplicate_semicolon,extra_empty_lines,no_blank_lines_after_class_opening,no_empty_lines_after_phpdocs,operators_spaces,spaces_before_semicolon,ternary_spaces,concat_with_spaces,short_array_syntax,phpdoc_no_access,remove_leading_slash_use" />
...@@ -109,12 +110,12 @@ ...@@ -109,12 +110,12 @@
<!-- PHPUnit --> <!-- PHPUnit -->
<target name="phpunit" description="Run tests"> <target name="phpunit" description="Run tests">
<exec dir="${srcdir}/module/VuFind/tests" command="NODE_PATH=${nodepath} VUFIND_LOCAL_DIR=${srcdir}/local VUFIND_URL=${vufindurl} phpunit -dzend.enable_gc=0 --log-junit ${builddir}/reports/phpunit.xml --coverage-clover ${builddir}/reports/coverage/clover.xml --coverage-html ${builddir}/reports/coverage/ ${phpunit_extra_params}" passthru="true" checkreturn="true" /> <exec dir="${srcdir}/module/VuFind/tests" command="NODE_PATH=${nodepath} VUFIND_MINK_DRIVER=${mink_driver} VUFIND_LOCAL_DIR=${srcdir}/local VUFIND_URL=${vufindurl} phpunit -dzend.enable_gc=0 --log-junit ${builddir}/reports/phpunit.xml --coverage-clover ${builddir}/reports/coverage/clover.xml --coverage-html ${builddir}/reports/coverage/ ${phpunit_extra_params}" passthru="true" checkreturn="true" />
</target> </target>
<!-- PHPUnit without logging output --> <!-- PHPUnit without logging output -->
<target name="phpunitfast" description="Run tests"> <target name="phpunitfast" description="Run tests">
<exec dir="${srcdir}/module/VuFind/tests" command="NODE_PATH=${nodepath} VUFIND_LOCAL_DIR=${srcdir}/local VUFIND_URL=${vufindurl} phpunit -dzend.enable_gc=0 ${phpunit_extra_params}" passthru="true" checkreturn="true" /> <exec dir="${srcdir}/module/VuFind/tests" command="NODE_PATH=${nodepath} VUFIND_MINK_DRIVER=${mink_driver} VUFIND_LOCAL_DIR=${srcdir}/local VUFIND_URL=${vufindurl} phpunit -dzend.enable_gc=0 ${phpunit_extra_params}" passthru="true" checkreturn="true" />
</target> </target>
<!-- Install and Activate VuFind --> <!-- Install and Activate VuFind -->
......
...@@ -111,9 +111,11 @@ abstract class MinkTestCase extends DbTestCase ...@@ -111,9 +111,11 @@ abstract class MinkTestCase extends DbTestCase
protected function getMinkDriver() protected function getMinkDriver()
{ {
if (self::$driver === false) { if (self::$driver === false) {
self::$driver = new ZombieDriver( self::$driver = (getenv('VUFIND_MINK_DRIVER') === 'selenium')
new \Behat\Mink\Driver\NodeJS\Server\ZombieServer() ? new \Behat\Mink\Driver\Selenium2Driver('firefox')
); : new ZombieDriver(
new \Behat\Mink\Driver\NodeJS\Server\ZombieServer()
);
} }
return self::$driver; return self::$driver;
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment