Fixed bug: first_indexed value in change_tracker updated inappropriately.

Resolves VUFIND-835; thanks to Luke O'Sullivan for the fix.

module/VuFind/src/VuFind/Db/Table/ChangeTracker.php

@@ -203,7 +203,7 @@ class ChangeTracker extends Gateway
 
             // If first indexed is null, we're restoring a deleted record, so
             // we need to treat it as new -- we'll use the current time.
-            if (empty($this->first_indexed)) {
+            if (empty($row->first_indexed)) {
                 $row->first_indexed = $row->last_indexed;
             }
 

module/VuFind/tests/integration-tests/src/VuFindTest/Db/Table/ChangeTrackerTest.php

@@ -77,6 +77,10 @@ class ChangeTrackerTest extends \VuFindTest\Unit\DbTestCase
         $this->assertTrue(empty($row->deleted));
         $this->assertEquals($row->first_indexed, $row->last_indexed);
         $this->assertEquals($row->last_record_change, '2012-01-17 20:46:10');
+        $previousFirstIndexed = $row->first_indexed;
+
+        // Sleep two seconds to be sure timestamps change:
+        sleep(2);
 
         // Index a later record version -- this should lead to changes:
         $tracker->index($core, 'test1', 1326833176);
@@ -89,6 +93,9 @@ class ChangeTrackerTest extends \VuFindTest\Unit\DbTestCase
         );
         $this->assertEquals($row->last_record_change, '2012-01-17 20:46:16');
 
+        // Make sure the "first indexed" date hasn't changed!
+        $this->assertEquals($row->first_indexed, $previousFirstIndexed);
+
         // Delete the record:
         $tracker->markDeleted($core, 'test1');
         $row = $tracker->retrieve($core, 'test1');
@@ -108,6 +115,7 @@ class ChangeTrackerTest extends \VuFindTest\Unit\DbTestCase
         $this->assertTrue(is_object($row));
         $this->assertTrue(empty($row->deleted));
         $this->assertEquals($row->last_record_change, '2012-01-17 20:46:10');
+        $this->assertEquals($row->first_indexed, $row->last_indexed);
 
         // Clean up after ourselves:
         $tracker->delete(array('core' => $core));