Skip to content
Snippets Groups Projects
Commit eebeef95 authored by Ere Maijala's avatar Ere Maijala Committed by Robert Lange
Browse files

Alma: Improve error handling when placing hold. Lowercase apikey parameter.

parent 98e35532
No related merge requests found
...@@ -1369,7 +1369,7 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface ...@@ -1369,7 +1369,7 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface
// Create HTTP client with Alma API URL for title level requests // Create HTTP client with Alma API URL for title level requests
$client = $this->httpService->createClient( $client = $this->httpService->createClient(
$this->baseUrl . '/bibs/' . urlencode($mmsId) $this->baseUrl . '/bibs/' . urlencode($mmsId)
. '/requests?apiKey=' . urlencode($this->apiKey) . '/requests?apikey=' . urlencode($this->apiKey)
. '&user_id=' . urlencode($patronId) . '&user_id=' . urlencode($patronId)
. '&format=json' . '&format=json'
); );
...@@ -1379,7 +1379,7 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface ...@@ -1379,7 +1379,7 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface
$this->baseUrl . '/bibs/' . urlencode($mmsId) $this->baseUrl . '/bibs/' . urlencode($mmsId)
. '/holdings/' . urlencode($holId) . '/holdings/' . urlencode($holId)
. '/items/' . urlencode($itmId) . '/items/' . urlencode($itmId)
. '/requests?apiKey=' . urlencode($this->apiKey) . '/requests?apikey=' . urlencode($this->apiKey)
. '&user_id=' . urlencode($patronId) . '&user_id=' . urlencode($patronId)
. '&format=json' . '&format=json'
); );
...@@ -1419,6 +1419,7 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface ...@@ -1419,6 +1419,7 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface
return [ return [
'success' => false, 'success' => false,
'sysMessage' => $error->errorList->error[0]->errorMessage 'sysMessage' => $error->errorList->error[0]->errorMessage
?? 'hold_error_fail'
]; ];
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment