Simplified AJAX autocomplete method; moved array_values() into factory for...

Simplified AJAX autocomplete method; moved array_values() into factory for more consistent central behavior (this may not be necessary, but retaining it as a safety mechanism to prevent badly encoded output caused by associative arrays).

module/VuFind/src/VuFind/Autocomplete/Factory.php

@@ -124,6 +124,6 @@ class Factory
         }
 
         return (isset($handler) && is_object($handler))
-            ? $handler->getSuggestions($query) : array();
+            ? array_values($handler->getSuggestions($query)) : array();
     }
 }

module/VuFind/src/VuFind/Controller/AjaxController.php

@@ -912,13 +912,9 @@ class AjaxController extends AbstractBase
      */
     public function getACSuggestions()
     {
+        $query = $this->getRequest()->getQuery();
         return $this->output(
-            array_values(
-                \VuFind\Autocomplete\Factory::getSuggestions(
-                    $this->getRequest()->getQuery()
-                )
-            ),
-            self::STATUS_OK
+            \VuFind\Autocomplete\Factory::getSuggestions($query), self::STATUS_OK
         );
     }