Never set followup to lightbox. Otherwise e.g. Shibboleth login with...

Never set followup to lightbox. Otherwise e.g. Shibboleth login with ChoiceAuth will return to a lightbox page.

module/VuFind/src/VuFind/Controller/AbstractBase.php

@@ -261,16 +261,13 @@ class AbstractBase extends AbstractActionController
             $msg = 'You must be logged in first';
         }
 
-        // If we're doing off-site login requests,
-        // we don't want to return to the lightbox
+        // We don't want to return to the lightbox
         $serverUrl = $this->getServerUrl();
-        if ($this->getAuthManager()->getSessionInitiator($serverUrl)) {
-            $serverUrl = str_replace(
-                ['?layout=lightbox', '&layout=lightbox'],
-                ['?', '&'],
-                $serverUrl
-            );
-        }
+        $serverUrl = str_replace(
+            ['?layout=lightbox', '&layout=lightbox'],
+            ['?', '&'],
+            $serverUrl
+        );
 
         // Store the current URL as a login followup action
         $this->followup()->store($extras, $serverUrl);