Move cover URL generation to its own class. (#718) (c55ddfb9) · Commits · ubl / finc / vufind · GitLab

Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

vufind
- Activity
- Members
- Labels
- Issues
  0
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

Admin message

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

ubl
finc
vufind
Commits
c55ddfb9

Commit c55ddfb9 authored 8 years ago by

Demian Katz

Downloads
- Patches
- Plain Diff

Move cover URL generation to its own class. (#718)

- Allows easier code reuse.
- Eliminates redundant route calculation.

parent 4c012e6d

Branches

Tags

Changes 7

Hide whitespace changes

Inline Side-by-side

Showing

module/VuFind/config/module.config.php 1 addition, 0 deletions

module/VuFind/config/module.config.php
module/VuFind/src/VuFind/Cover/Router.php 86 additions, 0 deletions

module/VuFind/src/VuFind/Cover/Router.php
module/VuFind/src/VuFind/Service/Factory.php 14 additions, 0 deletions

module/VuFind/src/VuFind/Service/Factory.php
module/VuFind/src/VuFind/View/Helper/Root/Factory.php 5 additions, 1 deletion

module/VuFind/src/VuFind/View/Helper/Root/Factory.php
module/VuFind/src/VuFind/View/Helper/Root/Record.php 24 additions, 16 deletions

module/VuFind/src/VuFind/View/Helper/Root/Record.php
module/VuFind/tests/unit-tests/src/VuFindTest/Cover/RouterTest.php 104 additions, 0 deletions

...Find/tests/unit-tests/src/VuFindTest/Cover/RouterTest.php
module/VuFind/tests/unit-tests/src/VuFindTest/View/Helper/Root/RecordTest.php 2 additions, 1 deletion

...unit-tests/src/VuFindTest/View/Helper/Root/RecordTest.php

with 236 additions and 18 deletions

0% or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment