Fix problems with EDS internal links. (#1873)

- Include quotes in search terms to improve accuracy
- Ensure correct URL encoding
- Add subject to list of search types

config/vufind/EDS.ini

@@ -199,6 +199,7 @@ translated_facets[] = SourceType
 AllFields           = "All Fields"
 TI                  = Title
 AU                  = Author
+SU                  = Subject
 
 ; This section defines which search options will be included on the advanced
 ; search screen.  All the notes above [Basic_Searches] also apply here.

module/VuFind/src/VuFind/RecordDriver/EDS.php

@@ -579,9 +579,9 @@ class EDS extends DefaultRecord
                 if (in_array($group, $allowed_searchlink_groups)) {
                     $type = strtoupper($group);
                     $link_xml = '/<searchLink fieldCode="([^\"]*)" '
-                        . 'term="%22([^\"]*)%22">/';
-                    $link_html
-                        = "<a href=\"../EDS/Search?lookfor=$2&amp;type={$type}\">";
+                        . 'term="(%22[^\"]*%22)">/';
+                    $link_html = '<a href="../EDS/Search?lookfor=$2&amp;type='
+                        . urlencode($type) . '">';
                     $data = preg_replace($link_xml, $link_html, $data);
                     $data = str_replace('</searchLink>', '</a>', $data);
                 }