Fix bug: only Solr tags display in favorites.

- We were overly aggressive in our default filtering behavior, so the tag list in the "My Favorites" area only showed Solr-related tags.

module/VuFind/src/VuFind/Db/Row/User.php

@@ -237,12 +237,12 @@ class User extends RowGateway implements \VuFind\Db\Table\DbTableAwareInterface,
      * @param int    $listId     Filter for tags tied to a specific list (null for no
      * filter).
      * @param string $source     Filter for tags tied to a specific record source.
+     * (null for no filter).
      *
      * @return \Zend\Db\ResultSet\AbstractResultSet
      */
-    public function getTags($resourceId = null, $listId = null,
-        $source = DEFAULT_SEARCH_BACKEND
-    ) {
+    public function getTags($resourceId = null, $listId = null, $source = null)
+    {
         return $this->getDbTable('Tags')
             ->getForUser($this->id, $resourceId, $listId, $source);
     }
@@ -255,13 +255,13 @@ class User extends RowGateway implements \VuFind\Db\Table\DbTableAwareInterface,
      * for no filter).
      * @param int    $listId     Filter for tags tied to a specific list (null for no
      * filter).
-     * @param string $source     Filter for tags tied to a specific record source.
+     * @param string $source     Filter for tags tied to a specific record source
+     * (null for no filter).
      *
      * @return string
      */
-    public function getTagString($resourceId = null, $listId = null,
-        $source = DEFAULT_SEARCH_BACKEND
-    ) {
+    public function getTagString($resourceId = null, $listId = null, $source = null)
+    {
         $myTagList = $this->getTags($resourceId, $listId, $source);
         $tagStr = '';
         if (count($myTagList) > 0) {

module/VuFind/src/VuFind/Db/Table/Tags.php

@@ -272,12 +272,13 @@ class Tags extends Gateway
      * for no filter).
      * @param int    $listId     Filter for tags tied to a specific list (null for no
      * filter).
-     * @param string $source     Filter for tags tied to a specific record source.
+     * @param string $source     Filter for tags tied to a specific record source
+     * (null for no filter).
      *
      * @return \Zend\Db\ResultSet\AbstractResultSet
      */
     public function getForUser($userId, $resourceId = null, $listId = null,
-        $source = DEFAULT_SEARCH_BACKEND
+        $source = null
     ) {
         $callback = function ($select) use ($userId, $resourceId, $listId, $source) {
             $select->columns(
@@ -310,8 +311,11 @@ class Tags extends Gateway
                 ->equalTo(
                     'ur.list_id', 'rt.list_id',
                     Predicate::TYPE_IDENTIFIER, Predicate::TYPE_IDENTIFIER
-                )
-                ->equalTo('r.source', $source);
+                );
+            
+            if (null !== $source) {
+                $select->where->equalTo('r.source', $source);
+            }
 
             if (null !== $resourceId) {
                 $select->where->equalTo('r.record_id', $resourceId);