Fix spinners to actually spin in request screens.

themes/bootstrap3/js/hold.js

@@ -8,7 +8,7 @@ function setUpHoldRequestForm(recordId) {
       $('#pickUpLocation').attr('disabled', 'disabled');
       return;
     }
-    $('#pickUpLocationLabel i').addClass("fa fa-spinner icon-spin");
+    $('#pickUpLocationLabel i').addClass("fa fa-spinner fa-spin");
     var params = {
       method: 'getRequestGroupPickupLocations',
       id: recordId,
@@ -31,11 +31,11 @@ function setUpHoldRequestForm(recordId) {
           $('#pickUpLocation').append(option);
         });
 
-        $('#pickUpLocationLabel i').removeClass("fa fa-spinner icon-spin");
+        $('#pickUpLocationLabel i').removeClass("fa fa-spinner fa-spin");
         $('#pickUpLocation').removeAttr('disabled');
       })
       .fail(function holdPickupLocationsFail(/*response*/) {
-        $('#pickUpLocationLabel i').removeClass("fa fa-spinner icon-spin");
+        $('#pickUpLocationLabel i').removeClass("fa fa-spinner fa-spin");
         $('#pickUpLocation').removeAttr('disabled');
       });
   });

themes/bootstrap3/js/ill.js

@@ -3,7 +3,7 @@
 function setUpILLRequestForm(recordId) {
   $("#ILLRequestForm #pickupLibrary").change(function illPickupChange() {
     $("#ILLRequestForm #pickupLibraryLocation option").remove();
-    $("#ILLRequestForm #pickupLibraryLocationLabel i").addClass("fa fa-spinner icon-spin");
+    $("#ILLRequestForm #pickupLibraryLocationLabel i").addClass("fa fa-spinner fa-spin");
     var url = VuFind.path + '/AJAX/JSON?' + $.param({
       id: recordId,
       method: 'getLibraryPickupLocations',
@@ -22,10 +22,10 @@ function setUpILLRequestForm(recordId) {
           }
           $("#ILLRequestForm #pickupLibraryLocation").append(option);
         });
-        $("#ILLRequestForm #pickupLibraryLocationLabel i").removeClass("fa fa-spinner icon-spin");
+        $("#ILLRequestForm #pickupLibraryLocationLabel i").removeClass("fa fa-spinner fa-spin");
       })
       .fail(function illPickupLocationsFail(/*response*/) {
-        $("#ILLRequestForm #pickupLibraryLocationLabel i").removeClass("fa fa-spinner icon-spin");
+        $("#ILLRequestForm #pickupLibraryLocationLabel i").removeClass("fa fa-spinner fa-spin");
       });
   });
   $("#ILLRequestForm #pickupLibrary").change();