Skip to content
Snippets Groups Projects
Commit 99ace1fc authored by Dorian Merz's avatar Dorian Merz
Browse files

refs #18015 [master] code cleanup

* remove unnecessary (and error prone) function
* bugfix in data-titleUniform: avoids undefined index error
parent 835f253a
No related merge requests found
...@@ -82,30 +82,6 @@ trait MultiDataFieldsTrait ...@@ -82,30 +82,6 @@ trait MultiDataFieldsTrait
return $final; return $final;
} }
/**
* return render details for titleUniform data set
* @return callback
*/
public function titleUniform($data, $options, $driver)
{
// Sort the data:
$final = [];
foreach ($data as $type => $values) {
$final[] = [
'label' => $driver->tryMethod('isRDA')
? 'rda_original_title'
: 'non_rda_original_title',
'values' => [$type => $values],
'options' => [
'pos' => $options['pos'],
'renderType' => 'RecordDriverTemplate',
'template' => 'data-titleUniform.phtml',
],
];
}
return $final;
}
/** /**
* return render details for events data set * return render details for events data set
* @return callback * @return callback
......
<!-- finc: RecordDriver - DefaultRecord - data-titleUniform --> <!-- finc: RecordDriver - DefaultRecord - data-titleUniform -->
<?php if (!empty($data)): ?> <?php if (!empty($data)): ?>
<?php if (is_array($data)): ?> <?php if (is_array($data)): ?>
<?php if ($data['titleUniform']): ?> <?php if (isset($data['titleUniform'])): ?>
<a href="<?= $this->record($this->driver)->getLink('titleUniform', $data['titleUniform']) ?>"> <a href="<?= $this->record($this->driver)->getLink('titleUniform', $data['titleUniform']) ?>">
<?php endif; ?> <?php endif; ?>
<?= $this->escapeHtml($data['title']) ?> <?= $this->escapeHtml($data['title']) ?>
<?php if ($data['titleUniform']): ?> <?php if (isset($data['titleUniform'])): ?>
</a> </a>
<?php endif; ?> <?php endif; ?>
<?php if (isset($data['lang'])): ?> &#x27E8;<?= $this->escapeHtml($data['lang']) ?>&#x27E9;<?php endif; ?> <?php if (isset($data['lang'])): ?> &#x27E8;<?= $this->escapeHtml($data['lang']) ?>&#x27E9;<?php endif; ?>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment