Added param default; removed unreachable code; expanded tests.

module/VuFind/src/VuFind/Record/Router.php

@@ -125,7 +125,7 @@ class Router
      *
      * @return array
      */
-    public function getRouteDetails($driver, $routeSuffix,
+    public function getRouteDetails($driver, $routeSuffix = '',
         $extraParams = array()
     ) {
         // Extract source and ID from driver or string:
@@ -146,9 +146,6 @@ class Router
         // Build URL parameters:
         $params = $extraParams;
         $params['id'] = $id;
-        if (!empty($action)) {
-            $params['action'] = $action;
-        }
 
         // Determine route based on naming convention (default VuFind route is
         // the exception to the rule):

module/VuFind/tests/unit-tests/src/VuFindTest/Record/RouterTest.php

@@ -56,7 +56,36 @@ class RouterTest extends TestCase
         $router = $this->getRouter($driver);
         $this->assertEquals(
             array('params' => array('id' => 'test'), 'route' => 'record'),
-            $router->getRouteDetails($driver, '')
+            $router->getRouteDetails($driver)
+        );
+    }
+
+    /**
+     * Test routing with driver object.
+     *
+     * @return void
+     */
+    public function testRoutingWithString()
+    {
+        $router = $this->getRouter();
+        $this->assertEquals(
+            array('params' => array('id' => 'test'), 'route' => 'summonrecord'),
+            $router->getRouteDetails('Summon|test')
+        );
+    }
+
+    /**
+     * Test action routing with driver object.
+     *
+     * @return void
+     */
+    public function testActionRoutingWithDriver()
+    {
+        $driver = $this->getDriver();
+        $router = $this->getRouter($driver);
+        $this->assertEquals(
+            array('params' => array('id' => 'test'), 'route' => 'record-sms'),
+            $router->getActionRouteDetails($driver, 'SMS')
         );
     }