Fixed bug: translation broken by displayLanguageOption helper.

- Resolves VUFIND-1111

module/VuFind/src/VuFind/View/Helper/Root/DisplayLanguageOption.php

@@ -53,9 +53,7 @@ class DisplayLanguageOption extends \Zend\View\Helper\AbstractHelper
      */
     public function __construct(TranslatorInterface $translator)
     {
-        // Clone the translator; we need to switch language for the purposes
-        // of this plugin, but we don't want that change to happen globally.
-        $this->translator = clone($translator);
+        $this->translator = $translator;
         try {
             $this->translator->addTranslationFile(
                 'ExtendedIni',

module/VuFind/src/VuFind/View/Helper/Root/Factory.php

@@ -139,8 +139,11 @@ class Factory
      */
     public static function getDisplayLanguageOption(ServiceManager $sm)
     {
+        // We want to construct a separate translator instance for this helper,
+        // since it configures different language/locale than the core shared
+        // instance!
         return new DisplayLanguageOption(
-            $sm->getServiceLocator()->get('VuFind\Translator')
+            \VuFind\Service\Factory::getTranslator($sm->getServiceLocator())
         );
     }