Minor API fixes (#877)

- Added error handling to Swagger spec fragment parsing
- Fixed a phpdoc mistake
- Tweaked code style

module/VuFindApi/src/VuFindApi/Controller/ApiController.php

@@ -108,6 +108,12 @@ class ApiController extends \VuFind\Controller\AbstractBase
         foreach ($this->apiControllers as $controller) {
             $api = $controller->getSwaggerSpecFragment();
             $specs = json_decode($api, true);
+            if (null === $specs) {
+                throw new \Exception(
+                    'Could not parse Swagger spec fragment of '
+                    . get_class($controller)
+                );
+            }
             foreach ($specs as $key => $spec) {
                 if (isset($results[$key])) {
                     $results[$key] = array_merge($results[$key], $spec);

module/VuFindApi/src/VuFindApi/Controller/ApiInterface.php

@@ -46,7 +46,7 @@ interface ApiInterface
      * Get Swagger specification JSON fragment for services provided by the
      * controller
      *
-     * @return \Zend\Http\Response
+     * @return string
      */
     public function getSwaggerSpecFragment();
 }

module/VuFindApi/src/VuFindApi/Controller/SearchApiController.php

@@ -222,8 +222,7 @@ class SearchApiController extends \VuFind\Controller\AbstractSearch
 
         $this->determineOutputMode();
 
-        if ($result = $this->isAccessDenied($this->searchAccessPermission)
-        ) {
+        if ($result = $this->isAccessDenied($this->searchAccessPermission)) {
             return $result;
         }