Treat missing or unknown dueStatus as normal in GetUserTransactions. (#1577)

6d8d80f1 · Ere Maijala · Robert Lange · 28c8bc9e · 6d8d80f1
Commit 6d8d80f1 authored 5 years ago by Ere Maijala Committed by Robert Lange 2 years ago
--- a/module/VuFind/src/VuFind/AjaxHandler/GetUserTransactions.php
+++ b/module/VuFind/src/VuFind/AjaxHandler/GetUserTransactions.php
@@ -64,15 +64,16 @@ class GetUserTransactions extends AbstractIlsAndUserAction
            'overdue' => 0
        ];
        foreach ($items['records'] as $item) {
-            if (!isset($item['dueStatus'])) {
+            switch ($item['dueStatus'] ?? '') {
-                continue;
+            case 'due':
-            }
+                $counts['warn']++;
-            if ($item['dueStatus'] == 'overdue') {
+                break;
-                $counts['overdue'] += 1;
+            case 'overdue':
-            } elseif ($item['dueStatus'] == 'due') {
+                $counts['overdue']++;
-                $counts['warn'] += 1;
+                break;
-            } else {
+            default:
-                $counts['ok'] += 1;
+                $counts['ok']++;
+                break;
            }
        }
        return $this->formatResponse($counts);