Revert "Move record number to label to prevent empty labels. May need additional styling."

This reverts commit aeaa5100.

module/VuFind/src/VuFind/View/Helper/Root/Record.php

@@ -414,12 +414,13 @@ class Record extends AbstractHelper
      *
      * @return string
      */
-    public function getCheckbox($idPrefix = '', $formAttr = false, $number = null)
+    public function getCheckbox($idPrefix = '', $formAttr = false)
     {
+        static $checkboxCount = 0;
         $id = $this->driver->getSourceIdentifier() . '|'
             . $this->driver->getUniqueId();
         $context
-            = ['id' => $id, 'count' => $number, 'prefix' => $idPrefix];
+            = ['id' => $id, 'count' => $checkboxCount++, 'prefix' => $idPrefix];
         if ($formAttr) {
             $context['formAttr'] = $formAttr;
         }

themes/bootstrap3/templates/record/checkbox.phtml

 <label class="record-checkbox hidden-print">
   <input class="checkbox-select-item" type="checkbox" name="ids[]" value="<?=$this->escapeHtmlAttr($this->id) ?>"<? if(isset($this->formAttr)): ?> form="<?=$this->formAttr ?>"<? endif; ?>/>
   <span class="checkbox-icon"></span>
-  <?=$this->count ?>
 </label>
 <input type="hidden" name="idsAll[]" value="<?=$this->escapeHtmlAttr($this->id) ?>"<? if(isset($this->formAttr)): ?> form="<?=$this->formAttr ?>"<? endif; ?>/>

themes/bootstrap3/templates/search/list-list.phtml

@@ -4,8 +4,11 @@
   <? $recordNumber = $this->results->getStartRecord() + $i-$this->indexStart; ?>
   <div id="result<?=$i++ ?>" class="result<?=$current->supportsAjaxStatus()?' ajaxItem':''?>">
     <? if (isset($this->showCheckboxes) && $this->showCheckboxes): ?>
-      <?=$this->record($current)->getCheckbox('', 'search-cart-form', $recordNumber)?>
+      <?=$this->record($current)->getCheckbox('', 'search-cart-form')?>
     <? endif; ?>
+    <div class="record-number">
+      <?=$recordNumber ?>
+    </div>
     <?=$this->record($current)->getSearchResult('list')?>
   </div>
 <? endforeach; ?>

themes/sandal/less/search.less

@@ -26,10 +26,6 @@
   .media-left { padding-left: 0; }
   .media-right { padding-right: 0; }
   .record-cover img { border: 1px solid @gray-lighter; }
-  .record-checkbox {
-    flex: 0 3rem;
-    text-align: center;
-  }
   .record-number {
     font-size: @reduced-font-size;
     font-weight: bold;