Record toolbar role improvements.

5c0bf28a · Chris Hallberg · Demian Katz · 42f80ca3 · 5c0bf28a
Commit 5c0bf28a authored 4 years ago by Chris Hallberg Committed by Demian Katz 4 years ago
--- a/themes/bootstrap3/templates/RecordDriver/DefaultRecord/toolbar.phtml
+++ b/themes/bootstrap3/templates/RecordDriver/DefaultRecord/toolbar.phtml
@@ -4,42 +4,44 @@
    $this->headScript()->appendFile('https://s7.addthis.com/js/250/addthis_widget.js?pub=' . urlencode($addThis));
  }
 ?>
-<ul class="record-nav nav nav-pills hidden-print">
+<nav class="record-nav hidden-print">
-  <?php if (count($this->driver->getCitationFormats()) > 0): ?>
+  <ul class="nav nav-pills" aria-label="<?=$this->transEsc('ajaxview_label_tools'); ?>">
-    <li><a class="cite-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'Cite')?>" rel="nofollow"><i class="fa fa-asterisk" aria-hidden="true"></i> <?=$this->transEsc('Cite this')?></a></li>
+    <?php if (count($this->driver->getCitationFormats()) > 0): ?>
-  <?php endif; ?>
+      <li role="none"><a class="cite-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'Cite')?>" rel="nofollow"><i class="fa fa-asterisk" aria-hidden="true"></i> <?=$this->transEsc('Cite this')?></a></li>
-  <?php if ($this->accountCapabilities()->getSmsSetting() !== 'disabled'): ?>
+    <?php endif; ?>
-    <li><a class="sms-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'SMS')?>" rel="nofollow"><i class="fa fa-mobile" aria-hidden="true"></i> <?=$this->transEsc('Text this')?></a></li>
+    <?php if ($this->accountCapabilities()->getSmsSetting() !== 'disabled'): ?>
-  <?php endif; ?>
+      <li role="none"><a class="sms-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'SMS')?>" rel="nofollow"><i class="fa fa-mobile" aria-hidden="true"></i> <?=$this->transEsc('Text this')?></a></li>
-  <li><a class="mail-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'Email')?>" rel="nofollow"><i class="fa fa-envelope" aria-hidden="true"></i> <?=$this->transEsc('Email this')?></a></li>
+    <?php endif; ?>
+    <li role="none"><a class="mail-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'Email')?>" rel="nofollow"><i class="fa fa-envelope" aria-hidden="true"></i> <?=$this->transEsc('Email this')?></a></li>
-  <?php $exportFormats = $this->export()->getFormatsForRecord($this->driver); ?>
+    <?php $exportFormats = $this->export()->getFormatsForRecord($this->driver); ?>
-  <?php if(count($exportFormats) > 0): ?>
+    <?php if(count($exportFormats) > 0): ?>
-    <li class="dropdown">
+      <li role="none" class="dropdown">
-      <a class="export-toggle dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" href="<?=$this->recordLink()->getActionUrl($this->driver, 'Export')?>" rel="nofollow" aria-expanded="false" aria-controls="export-options"><i class="fa fa-list-alt" aria-hidden="true"></i> <?=$this->transEsc('Export Record') ?></a>
+        <a class="export-toggle dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" href="<?=$this->recordLink()->getActionUrl($this->driver, 'Export')?>" rel="nofollow" aria-expanded="false" aria-controls="export-options"><i class="fa fa-list-alt" aria-hidden="true"></i> <?=$this->transEsc('Export Record') ?></a>
-      <ul class="dropdown-menu" id="export-options" role="menu">
+        <ul class="dropdown-menu" id="export-options" role="menu">
-        <?php foreach ($exportFormats as $exportFormat): ?>
+          <?php foreach ($exportFormats as $exportFormat): ?>
-          <li role="none">
+            <li role="none">
-            <a <?php if ($this->export()->needsRedirect($exportFormat)): ?>target="<?=$this->escapeHtmlAttr($exportFormat)?>Main" <?php endif; ?>href="<?=$this->recordLink()->getActionUrl($this->driver, 'Export')?>?style=<?=$this->escapeHtmlAttr($exportFormat)?>" rel="nofollow" role="menuitem">
+              <a <?php if ($this->export()->needsRedirect($exportFormat)): ?>target="<?=$this->escapeHtmlAttr($exportFormat)?>Main" <?php endif; ?>href="<?=$this->recordLink()->getActionUrl($this->driver, 'Export')?>?style=<?=$this->escapeHtmlAttr($exportFormat)?>" rel="nofollow" role="menuitem">
-              <?=$this->transEsc('Export to')?> <?=$this->transEsc($this->export()->getLabelForFormat($exportFormat))?>
+                <?=$this->transEsc('Export to')?> <?=$this->transEsc($this->export()->getLabelForFormat($exportFormat))?>
-            </a>
+              </a>
-          </li>
+            </li>
-        <?php endforeach; ?>
+          <?php endforeach; ?>
-      </ul>
+        </ul>
-    </li>
+      </li>
-  <?php endif; ?>
+    <?php endif; ?>
-  <?php if ($this->userlist()->getMode() !== 'disabled'): ?>
+    <?php if ($this->userlist()->getMode() !== 'disabled'): ?>
-    <li>
+      <li role="none">
-      <?php if ($this->permission()->allowDisplay('feature.Favorites')): ?>
+        <?php if ($this->permission()->allowDisplay('feature.Favorites')): ?>
-        <a class="save-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'Save')?>" rel="nofollow"><i class="fa fa-star" aria-hidden="true"></i> <?=$this->transEsc('Add to favorites')?></a>
+          <a class="save-record" data-lightbox href="<?=$this->recordLink()->getActionUrl($this->driver, 'Save')?>" rel="nofollow"><i class="fa fa-star" aria-hidden="true"></i> <?=$this->transEsc('Add to favorites')?></a>
-      <?php elseif ($block = $this->permission()->getAlternateContent('feature.Favorites')): ?>
+        <?php elseif ($block = $this->permission()->getAlternateContent('feature.Favorites')): ?>
-        <?=$block?>
+          <?=$block?>
-      <?php endif; ?>
+        <?php endif; ?>
-    </li>
+      </li>
-  <?php endif; ?>
+    <?php endif; ?>
-  <?php if (!empty($addThis)): ?>
+    <?php if (!empty($addThis)): ?>
-    <li><a class="addThis addthis_button" href="https://www.addthis.com/bookmark.php?v=250&amp;pub=<?=urlencode($addThis)?>"><i class="fa fa-bookmark" aria-hidden="true"></i> <?=$this->transEsc('Bookmark')?></a></li>
+      <li role="none"><a class="addThis addthis_button" href="https://www.addthis.com/bookmark.php?v=250&amp;pub=<?=urlencode($addThis)?>"><i class="fa fa-bookmark" aria-hidden="true"></i> <?=$this->transEsc('Bookmark')?></a></li>
-  <?php endif; ?>
+    <?php endif; ?>
-  <?=$this->render('record/cart-buttons.phtml', ['id' => $this->driver->getUniqueId(), 'source' => $this->driver->getSourceIdentifier()]); ?>
+    <?=$this->render('record/cart-buttons.phtml', ['id' => $this->driver->getUniqueId(), 'source' => $this->driver->getSourceIdentifier()]); ?>
-</ul>
+  </ul>
+</nav>