Skip to content
Snippets Groups Projects
Commit 56fea3a8 authored by Fabian Erni's avatar Fabian Erni Committed by Demian Katz
Browse files

Update module/VuFind/src/VuFind/Controller/Plugin/Holds.php

For the Aleph Driver, it's possible that the item ID (id from route) and the holding ID (id from query) are different. With the += operator for merging, the id attribute from $keyValueArray was not used and an invalid REST url was sent to the ILS.
I'm not sure why the record id is loaded from the route here. With this fix, it's only used as a fallback when not defined in the query as a HMACKeys-variable of the ILS.

Aleph uses id:item_id which causes the conflict here.
parent e1cb95cd
No related merge requests found
...@@ -212,7 +212,7 @@ class Holds extends AbstractPlugin ...@@ -212,7 +212,7 @@ class Holds extends AbstractPlugin
$gatheredDetails['id'] = $params->fromRoute('id'); $gatheredDetails['id'] = $params->fromRoute('id');
// Get Values Passed from holdings.php // Get Values Passed from holdings.php
$gatheredDetails += $keyValueArray; $gatheredDetails = array_merge($gatheredDetails, $keyValueArray);
return $gatheredDetails; return $gatheredDetails;
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment