refs #16912

* fixes accessibility of add-to-bookbag in bulk action buttons
* fixes minor glitch in adv search home header

* implements an even better solution: we don't need a finc-specific bulk-action-bttn template anymore
* deleted the finc template, we use BS default, which works fine

themes/finc/scss/compiled.scss

@@ -80,6 +80,11 @@ body {
   // for mobile
   padding-top: $navbar-height-xs;
 
+  // make xception for adv. search home
+  &.template-name-advanced {
+    padding-top: 3.25rem;
+  }
+
   // for tablet
   @media (min-width: $screen-sm-min) {
     padding-top: $navbar-height-sm;
@@ -1064,6 +1069,10 @@ header,
   // body -> padding-top would need to be taller than navbar minimum-height
   min-height: $navbar-height;
 
+ .template-name-advanced & {
+    min-height: 3rem;
+  }
+
   @media only screen and (max-width: $screen-xs-max) {
     header & {
       min-height: 5rem;
@@ -1284,8 +1293,13 @@ header,
 .navbar-left {
   // push searchbox down on mobile
   @media only screen and (max-width: $screen-xs-max) {
-    margin-bottom: ($grid-gutter-width / 4);
+    display: contents;
+    margin-bottom: 0;
     margin-top: 0;
+
+    &.navbar-form {
+      padding-top: 0;
+    }
   }
 }
 
@@ -1326,13 +1340,6 @@ header,
       margin-top: $inputs-top-margin;
     }
   }
-
-  // make search area fit on Tablets up to 994px by reducing buttons
-  .find-label {
-    @media only screen and (min-width: $screen-sm-min) and (max-width: 994px) {
-      display: none;
-    }
-  }
 }
 
 //// Searchbox on Homepage
@@ -1462,6 +1469,7 @@ footer {
 ////// Bulk Action Toolbar
 .bulk-action-buttons,
 .bulkActionButtons {
+  clear: both;
   padding-bottom: ($grid-gutter-width / 2);
   padding-top: ($grid-gutter-width / 2);
 }

themes/finc/templates/myresearch/bulk-action-buttons.phtml

-<!-- finc: myresearch - bulkactionbuttons -->
-<?php if (isset($list)): ?>
-  <input type="hidden" name="listID" value="<?=$this->escapeHtmlAttr($list->id)?>"/>
-  <input type="hidden" name="listName" value="<?=$this->escapeHtmlAttr($list->title)?>"/>
-<?php endif; ?>
-<?php $user = $this->auth()->isLoggedIn(); ?>
-<div class="bulkActionButtons hidden-print">
-  <div class="bulk-checkbox">
-    <input type="checkbox" name="selectAll" class="checkbox-select-all" id="myresearchCheckAll"/>
-    <label for="myresearchCheckAll"><?=$this->transEsc('select_page')?> | <?=$this->transEsc('with_selected')?>:</label>
-  </div>
-
-  <?php /* Keep bulk-action-buttons class, finc-specific SCSS, CK */ ?>
-  <div class="btn-group bulk-action-buttons hidden-print">
-    <input class="btn btn-transparent" type="submit" name="email" value="<?=$this->transEsc('Email')?>" title="<?=$this->transEsc('email_selected')?>"/>
-    <?php if ((null !== $this->list && $this->list->editAllowed($user)) || null === $this->list && $user): ?>
-      <input class="btn btn-transparent" id="<?=$this->idPrefix?>delete_list_items_<?=!is_null($this->list) ? $this->escapeHtmlAttr($this->list->id) : ''?>" type="submit" name="delete" value="<?=$this->transEsc('Delete')?>" title="<?=$this->transEsc('delete_selected')?>"/>
-    <?php endif; ?>
-    <?php $exportOptions = $this->export()->getActiveFormats('bulk');
-    if (count($exportOptions) > 0): ?>
-      <input class="btn btn-transparent" type="submit" name="export" value="<?=$this->transEsc('Export')?>" title="<?=$this->transEsc('export_selected')?>"/>
-    <?php endif; ?>
-    <input class="btn btn-transparent" type="submit" name="print" value="<?=$this->transEsc('Print')?>" title="<?=$this->transEsc('print_selected')?>" data-lightbox-ignore/>
-    <?php if ($this->cart()->isActive()): ?>
-      <input class="btn btn-transparent" id="<?=$this->idPrefix?>updateCart" type="submit" name="add" value="<?=$this->transEsc('Add to Book Bag')?>"/>
-    <?php endif; ?>
-  </div>
-</div>
-<!-- finc: myresearch - bulkactionbuttons - END -->

themes/finc/templates/search/searchbox.phtml

@@ -65,10 +65,10 @@ $hiddenFilterParams = $this->searchTabs()->getCurrentHiddenFilterParams($this->s
         <input type="hidden" name="type" value="<?=$this->escapeHtmlAttr($handlers[0]['value'])?>"/>
       <?php endif; ?>
       <li>
-        <button type="submit" class="btn btn-primary"><i class="fa fa-search" aria-hidden="true"></i> <span class="find-label"><?=$this->transEsc("Find")?></span></button>
+        <button type="submit" class="btn btn-primary"><i class="fa fa-search" aria-hidden="true"></i> <span class="find-label sr-only"><?=$this->transEsc("Find")?></span></button>
       </li>
       <?php if ($advSearch): ?>
-        <li class="hidden-xs">
+        <li>
           <a href="<?=$this->url($advSearch) . ((isset($this->searchId) && $this->searchId) ? '?edit=' . $this->escapeHtmlAttr($this->searchId) : $hiddenFilterParams)?>" class="btn btn-transparent" role="button" rel="nofollow"><i class="fa fa-cog"></i> <span class="hidden-xs hidden-sm hidden-md"><?=$this->transEsc("Advanced")?></span></a>
         </li>
       <?php endif; ?>