refs #23387 [finc] remove erroneous href javascript: for button without javascript action

* also fix error in lightbox_form_cache.js after deleting item

themes/finc/js/lightbox_form_cache.js

@@ -29,7 +29,9 @@ document.addEventListener('DOMContentLoaded', function () {
     const inputs = Array.from(form.querySelectorAll('input:not([type=password])'))
         .concat(Array.from(form.querySelectorAll('textarea')));
     JSON.parse(cache.getItem(cacheKey) || '[]').forEach(function (value, index) {
-      inputs[index].value = value;
+      if (inputs[index]) {
+        inputs[index].value = value;
+      }
     });
 
     modal.querySelectorAll('a:not([data-reset-forms]):not(#cart-confirm-empty):not(#cart-confirm-delete)').forEach(function (link) {

themes/finc/templates/cart/cart.phtml

@@ -46,7 +46,7 @@
             <a href="javascript:" id="cart-confirm-delete" title="<?=$this->transEscAttr('confirm_delete')?>" role="menuitem"><?=$this->transEscAttr('confirm_dialog_yes')?></a>
           </li>
           <li role="none">
-            <a href="javascript:" role="menuitem"><?=$this->transEsc('confirm_dialog_no')?></a>
+            <a role="menuitem"><?=$this->transEsc('confirm_dialog_no')?></a>
           </li>
         </ul>
       </div>
@@ -59,7 +59,7 @@
             <a href="javascript:" id="cart-confirm-empty" title="<?=$this->transEscAttr('bookbag_confirm_empty')?>" role="menuitem"><?=$this->transEsc('confirm_dialog_yes')?></a>
           </li>
           <li role="none">
-            <a href="javascript:" id="cart-refuse-empty" role="menuitem"><?=$this->transEsc('confirm_dialog_no')?></a>
+            <a id="cart-refuse-empty" role="menuitem"><?=$this->transEsc('confirm_dialog_no')?></a>
           </li>
         </ul>
       </div>