Skip to content
Snippets Groups Projects
Commit 28e0085f authored by Demian Katz's avatar Demian Katz
Browse files

Factored out redundant if ($handler) checks.

parent c040124e
Branches
Tags
No related merge requests found
...@@ -135,12 +135,11 @@ class QueryBuilder implements QueryBuilderInterface ...@@ -135,12 +135,11 @@ class QueryBuilder implements QueryBuilderInterface
} }
$string = $query->getString() ?: '*:*'; $string = $query->getString() ?: '*:*';
$handler = $this->getSearchHandler($query->getHandler(), $string);
if (!($handler && $handler->hasExtendedDismax()) if ($handler = $this->getSearchHandler($query->getHandler(), $string)) {
&& $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) if (!$handler->hasExtendedDismax()
) { && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string)
if ($handler) { ) {
$string = $this->createAdvancedInnerSearchString($string, $handler); $string = $this->createAdvancedInnerSearchString($string, $handler);
if ($handler->hasDismax()) { if ($handler->hasDismax()) {
$oldString = $string; $oldString = $string;
...@@ -152,19 +151,17 @@ class QueryBuilder implements QueryBuilderInterface ...@@ -152,19 +151,17 @@ class QueryBuilder implements QueryBuilderInterface
$params->set('hl.q', $oldString); $params->set('hl.q', $oldString);
} }
} }
}
} else {
if ($handler && $handler->hasDismax()) {
$params->set('qf', implode(' ', $handler->getDismaxFields()));
$params->set('qt', $handler->getDismaxHandler());
foreach ($handler->getDismaxParams() as $param) {
$params->add(reset($param), next($param));
}
if ($handler->hasFilterQuery()) {
$params->add('fq', $handler->getFilterQuery());
}
} else { } else {
if ($handler) { if ($handler->hasDismax()) {
$params->set('qf', implode(' ', $handler->getDismaxFields()));
$params->set('qt', $handler->getDismaxHandler());
foreach ($handler->getDismaxParams() as $param) {
$params->add(reset($param), next($param));
}
if ($handler->hasFilterQuery()) {
$params->add('fq', $handler->getFilterQuery());
}
} else {
$string = $handler->createSimpleQueryString($string); $string = $handler->createSimpleQueryString($string);
} }
} }
...@@ -360,7 +357,6 @@ class QueryBuilder implements QueryBuilderInterface ...@@ -360,7 +357,6 @@ class QueryBuilder implements QueryBuilderInterface
* @param SearchHandler $handler Search handler * @param SearchHandler $handler Search handler
* *
* @return string * @return string
*
*/ */
protected function createAdvancedInnerSearchString($string, protected function createAdvancedInnerSearchString($string,
SearchHandler $handler SearchHandler $handler
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment