Use phpDocumentor.phar in phing (#1052)

- Installing phpDocumentor via Composer was causing dependency conflicts; this offers a more self-contained approach to using the tool.

build.xml

@@ -26,6 +26,7 @@
   <property name="snooze_multiplier" value="1" /><!-- can be used to slow down tests (selenium only) -->
   <property name="solr_startup_sleep" value="0" />
   <property name="solr_version" value="6.4.2" />
+  <property name="phpdoc_version" value="2.9.0" />
   <property name="php-cs-fixers" value="no_blank_lines_before_namespaces,function_call_space,trailing_spaces,unused_use,lowercase_keywords,encoding,parenthesis,php_closing_tag,visibility,duplicate_semicolon,extra_empty_lines,no_blank_lines_after_class_opening,no_empty_lines_after_phpdocs,operators_spaces,spaces_before_semicolon,ternary_spaces,concat_with_spaces,short_array_syntax,phpdoc_no_access,remove_leading_slash_use,eof_ending" />
 
 
@@ -36,8 +37,6 @@
     <property name="mysqlpwswitch" value="-p" />
   </then></if>
 
-  <includepath classpath="${srcdir}/vendor/phpdocumentor" />
-
   <!-- Main Target -->
   <target name="main" description="main target">
     <phingcall target="startup" />
@@ -121,8 +120,22 @@
 
   <!-- PHP API Documentation -->
   <target name="phpdoc">
-    <mkdir dir="${builddir}/apidocs"/>
+    <!-- GET phpDocumentor.phar -->
+    <if>
+      <not><available file="${srcdir}/vendor/bin/phpDocumentor-${phpdoc_version}.phar" /></not>
+      <then>
+        <httpget followRedirects="true" url="https://github.com/phpDocumentor/phpDocumentor2/releases/download/v${phpdoc_version}/phpDocumentor.phar" dir="${srcdir}/vendor/bin" filename="phpDocumentor-${phpdoc_version}.phar" />
+        <chmod mode="0755">
+          <fileset dir="${srcdir}/vendor/bin">
+            <include name="phpDocumentor-${phpdoc_version}.phar" />
+          </fileset>
+        </chmod>
+      </then>
+    </if>
+    <!-- Run phpdoc -->
+    <mkdir dir="${builddir}/apidocs" />
     <phpdoc2 title="VuFind API Documentation"
+      pharlocation="${srcdir}/vendor/bin/phpDocumentor-${phpdoc_version}.phar"
       destdir="${builddir}/apidocs">
       <fileset dir=".">
         <include name="module/*/src/**/*.php" />

composer.json

@@ -71,7 +71,6 @@
         "behat/mink": "1.7.1",
         "behat/mink-selenium2-driver": "1.3.1",
         "friendsofphp/php-cs-fixer": "1.11.6",
-        "phpdocumentor/phpdocumentor": "2.9.0",
         "phploc/phploc": "3.0.1",
         "phpmd/phpmd": "2.6.0",
         "phpunit/phpunit": "5.7.15",