refs #13770 remove 'Online Access' in record-details; add 'Online Access' in holdings-tab

module/finc/src/finc/View/Helper/Root/RecordDataFormatterFactory.php

@@ -131,9 +131,8 @@ class RecordDataFormatterFactory
             'child_records', 'getChildRecordCount', 'data-childRecords.phtml',
             ['allowZero' => false]
         );
-        $spec->setTemplateLine(
-            'Online Access', true, 'data-onlineAccess.phtml'
-        );
+        /* finc: remove 'Online Access' in record-details #13770 - VE */
+        /* $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml'); */
         $spec->setTemplateLine(
             'Related Items', 'getAllRecordLinks', 'data-allRecordLinks.phtml'
         );
@@ -181,9 +180,8 @@ class RecordDataFormatterFactory
         $spec->setTemplateLine(
             'Subjects', 'getAllSubjectHeadings', 'data-allSubjectHeadings.phtml'
         );
-        $spec->setTemplateLine(
-            'Online Access', true, 'data-onlineAccess.phtml'
-        );
+        /* finc: remove 'Online Access' in record-details #13770 - VE */
+        /* $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml'); */
         $spec->setTemplateLine(
             'Item Description', 'getGeneralNotes', 'data-escapeHtml.phtml'
         );
@@ -337,7 +335,8 @@ class RecordDataFormatterFactory
             'child_records', 'getChildRecordCount', 'data-childRecords.phtml',
             ['allowZero' => false]
         );
-        $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml');
+        /* finc: remove 'Online Access' in record-details #13770 - VE */
+        /* $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml'); */
         $spec->setTemplateLine(
             'Related Items', 'getAllRecordLinks', 'data-allRecordLinks.phtml'
         );
@@ -624,7 +623,8 @@ class RecordDataFormatterFactory
         $spec->setTemplateLine(
             'Subjects', 'getAllSubjectHeadings', 'data-allSubjectHeadings.phtml'
         );
-        $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml');
+        /* finc: remove 'Online Access' in record-details #13770 -VE */
+        /* $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml'); */
         $spec->setTemplateLine(
             'Related Items', 'getAllRecordLinks', 'data-allRecordLinks.phtml'
         );
@@ -725,7 +725,8 @@ class RecordDataFormatterFactory
             'child_records', 'getChildRecordCount', 'data-childRecords.phtml',
             ['allowZero' => false]
         );
-        $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml');
+        /* finc: remove 'Online Access' in record-details #13770 - VE */
+        /* $spec->setTemplateLine('Online Access', true, 'data-onlineAccess.phtml'); */
         $spec->setTemplateLine(
             'Related Items', 'getAllRecordLinks', 'data-allRecordLinks.phtml'
         );

themes/finc/templates/RecordTab/holdingsils.phtml

@@ -58,7 +58,30 @@ if (!empty($holdingTitleHold)): ?>
   </a>
 <? endif; ?>
 
-<? /* finc: #12682 remove "Internet" ($urls, $openUrlActive) from description-tab (identical information is included in core-template with "Online Access" ) - VE */ ?>
+<? /* finc: add 'Online Access' in holdings-tab #13770 - VE */ ?>
+<? if (!empty($urls) || $openUrlActive): ?>
+  <h3><?=$this->transEsc("Internet")?></h3>
+  <? if (!empty($urls)): ?>
+    <? foreach ($urls as $current): ?>
+      <a href="<?=$this->escapeHtmlAttr($this->proxyUrl($current['url']))?>"><?=$this->escapeHtml($current['desc'])?></a><br/>
+    <? endforeach; ?>
+  <? endif; ?>
+  <? /* finc-specific snippet - #9274 - replaces if ($openUrlActive): - CK */ ?>
+  <? if ($openUrlActive): ?>
+    <? if (empty($urls)): ?>
+      <? $fallbackUrls = $this->driver->tryMethod('getURLs');
+      if (!empty($fallbackUrls)): ?>
+        <span id="urlsHideable" style="display: none">
+          <? foreach ($fallbackUrls as $current): ?>
+            <a href="<?=$this->escapeHtmlAttr($this->proxyUrl($current['url']))?>" target="_blank"><?=$this->escapeHtml($current['desc'])?></a><br/>
+          <? endforeach; ?>
+        </span>
+      <? endif; ?>
+    <? endif; ?>
+    <?=$openUrl->renderTemplate()?>
+  <? endif; ?>
+  <? /* finc-specific snippet - #9274 - END */ ?>
+<? endif; ?>
 
 <? foreach ($holdings['holdings'] as $holding): ?>
   <? /* nxt line = finc-specific - #7841@56988450 - CK */ ?>