Symphony: properly report patronLogin failure

17557624 · Laura Hild · Demian Katz · dd152fff · 17557624
Commit 17557624 authored 10 years ago by Laura Hild Committed by Demian Katz 10 years ago
--- a/module/VuFind/src/VuFind/ILS/Driver/Symphony.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Symphony.php
@@ -968,18 +968,28 @@ class Symphony extends AbstractBase implements ServiceLocatorAwareInterface
            'cat_password' => $password,
        );
-        $resp = $this->makeRequest(
+        try {
-            'patron',
+            $resp = $this->makeRequest(
-            'lookupMyAccountInfo',
+                'patron',
-            array(
+                'lookupMyAccountInfo',
-                'includePatronInfo' => 'true',
+                array(
-                'includePatronAddressInfo' => 'true'
+                    'includePatronInfo' => 'true',
-            ),
+                    'includePatronAddressInfo' => 'true'
-            array(
+                ),
-                'login' => $username,
+                array(
-                'password' => $password,
+                    'login' => $username,
-            )
+                    'password' => $password,
-        );
+                )
+            );
+        } catch (SoapFault $e) {
+            $unableToLogin = 'ns0:com.sirsidynix.symws.service.'
+                . 'exceptions.SecurityServiceException.unableToLogin';
+            if ($e->faultcode == $unableToLogin) {
+                return null;
+            } else {
+                throw $e;
+            }
+        }
        $patron['id']      = $resp->patronInfo->$usernameField;
        $patron['library'] = $resp->patronInfo->patronLibraryID;