refs #19359 [fid_bbi] fix icons in links

* Make all icons in links clickable
* Fix position in Firefox
* Move link-with-icon SCSS to separate file

themes/fid_bbi/scss/blocks/icon.scss

@@ -29,26 +29,3 @@
     }
   }
 }
-
-.link-with-icon {
-  margin-left: g(1.25);
-  position: relative;
-
-  // Make icon and gap clickable
-  &::before {
-    content: '';
-    display: block;
-    height: g();
-    left: 0;
-    margin-left: g(-1.25);
-    position: absolute;
-    top: 0;
-    width: g(1.25);
-  }
-
-  > .icon {
-    margin-left: g(-1.25);
-    margin-right: g(.25);
-    position: absolute; // Prevent icons from increasing link height
-  }
-}

themes/fid_bbi/scss/blocks/link-with-icon.scss

+.link-with-icon {
+  margin-left: g(1.25);
+
+  > .icon {
+    margin-left: g(-1.25);
+    padding-right: g(.25);
+    pointer-events: auto;
+    position: absolute; // Prevent icons from increasing link height
+    width: g(1 + .25); // Account for padding
+  }
+}

themes/fid_bbi/scss/compiled.scss

@@ -37,6 +37,7 @@
 @import 'blocks/header';
 @import 'blocks/icon';
 @import 'blocks/item-list';
+@import 'blocks/link-with-icon';
 @import 'blocks/main';
 @import 'blocks/modal';
 @import 'blocks/nav';

themes/fid_bbi/scss/util/hacks.scss

@@ -103,7 +103,8 @@ a.active {
 // data-rvkNotation
 .link-with-icon[aria-expanded=true] {
   > .icon {
-    transform: rotate(180deg)
+    transform: rotate(180deg);
+    padding: 0 0 0 g(.25);
   }
 }