From f955f8ced6847f0df6c82e0900bd7c11952b582f Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Thu, 5 Nov 2020 15:55:18 +0100
Subject: [PATCH] refs #18129 [finc] set description for new kxp links without
 subfields
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* edit getURLs in SolrMarcFincTrait for marc 856 https://www.loc.gov/marc/bibliographic/bd856.html
** new: set description to full text if 856 ind.2 = 0 (resource) and other subfields missing (3, x, z, y)
** new: set description to further information if 856 ind.2 = 2 (related resource) and other subfields missing (3, x, z, y)
** keep: set description to Online Access if ind.2 = 0 and doi.org and ind1 = 0
* add translation for Further information and full text plain
** full text / Volltext
** Further informationen / Weiterführende Informationen
---
 local/languages/de.ini                              |  2 ++
 local/languages/en.ini                              |  4 +++-
 .../src/finc/RecordDriver/SolrMarcFincTrait.php     | 13 +++++--------
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/local/languages/de.ini b/local/languages/de.ini
index ee1c8afe326..b2a372c2da3 100644
--- a/local/languages/de.ini
+++ b/local/languages/de.ini
@@ -1933,6 +1933,8 @@ Wirtschaftswissenschaften = "Wirtschaftswissenschaften"
 #13402 Missing Translations in result-list
 Varying Title = "Alternativer Titel"
 Fulltext = "Volltext"
+Full Text = "Volltext"
+Further Information = "Weiterführende Informationen"
 Classification = "Klassifikation"
 Alternative Author Name = "Alternativer Autorenname"
 Alternative Corporate Name = "Körperschaftennamenalternative"
diff --git a/local/languages/en.ini b/local/languages/en.ini
index 411a6507469..b40a155ef59 100644
--- a/local/languages/en.ini
+++ b/local/languages/en.ini
@@ -1022,6 +1022,8 @@ Find Similar Items = Find Similar Items
 Footnotes = Footnotes
 Form of address = Form of address
 Friday = Friday
+Full Text = "Full Text"
+Further Information = "Further information"
 Gender = Gender
 Help and information material = Help and information material
 Here = Here
@@ -2042,7 +2044,7 @@ Wirtschaftswissenschaften = "Business and Economics"
 
 ; #13402 Missing Translations in result-list
 Varying Title = "Varying Title"
-Fulltext = "Fulltext"
+Fulltext = "Full text"
 Classification = "Classification"
 Alternative Author Name = "Alternative Author Name"
 Alternative Corporate Name = "Alternative Corporate Name"
diff --git a/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php b/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
index 803e6d9aad7..aaed7e69ea8 100644
--- a/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
+++ b/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
@@ -129,15 +129,12 @@ trait SolrMarcFincTrait
                             $tmpArr = array_unique($tmpArr);
                             $desc = implode(', ', $tmpArr);
 
-                            // If no description take url as description
-                            // For 856[40] url denoting resource itself
-                            // use "Online Access"/"Online-Zugang" #6109
+                            // #18129 for 856[40] url denoting resource itself
                             if (empty($desc)) {
-                                if ($indicator1 == 4
-                                    && $indicator2 == 0
-                                    && preg_match('!https?://.*?doi.org/!', $address)
-                                ) {
-                                    $desc = "Online Access";
+                                if ($indicator2 == 0) {
+                                    $desc = "Full Text";
+                                } elseif ($indicator2 == 2) {
+                                    $desc = "Further Information";
                                 } else {
                                     $desc = $address;
                                 }
-- 
GitLab