diff --git a/module/VuFind/src/VuFind/Config/PluginFactory.php b/module/VuFind/src/VuFind/Config/PluginFactory.php index 240569cdce2ef84be77be6ba56dfe9a4620f2a1c..58ddb24632efe912f0306e08eb162464211c3509 100644 --- a/module/VuFind/src/VuFind/Config/PluginFactory.php +++ b/module/VuFind/src/VuFind/Config/PluginFactory.php @@ -111,7 +111,7 @@ class PluginFactory implements AbstractFactoryInterface ) { $config->$section = $child->$section; } else { - foreach ($contents as $key => $value) { + foreach (array_keys($contents->toArray()) as $key) { $config->$section->$key = $child->$section->$key; } } diff --git a/module/VuFind/src/VuFind/ILS/Logic/Holds.php b/module/VuFind/src/VuFind/ILS/Logic/Holds.php index 2bba28794278f932c71977d77388b5c7151babe2..2368a5c851f3432efae216ac4fc4debd1d14050f 100644 --- a/module/VuFind/src/VuFind/ILS/Logic/Holds.php +++ b/module/VuFind/src/VuFind/ILS/Logic/Holds.php @@ -312,7 +312,6 @@ class Holds ? ($addlink && $copy['is_holdable']) : $addlink; if ($addlink) { - $holdLink = ""; if ($checkHolds['function'] == "getHoldLink") { /* Build opac link */ $holdings[$location_key][$copy_key]['link'] diff --git a/module/VuFind/src/VuFind/OAI/Server.php b/module/VuFind/src/VuFind/OAI/Server.php index 2efe60f0f611914ff7cad83493217eb7a0444e22..b1aa70c2b69a9be2e5c1c9ff56fb0992028ed545 100644 --- a/module/VuFind/src/VuFind/OAI/Server.php +++ b/module/VuFind/src/VuFind/OAI/Server.php @@ -512,9 +512,6 @@ class Server return; } - // Initialize the array of XML chunks to include in our response: - $xmlParts = array(); - // Copy the cursor from the parameters so we can track our current position // separately from our initial position! $currentCursor = $params['cursor']; diff --git a/module/VuFind/src/VuFind/Recommend/SwitchQuery.php b/module/VuFind/src/VuFind/Recommend/SwitchQuery.php index 816f8012390eef239e19c1be7befb5dbf9d3e57f..eec349f56ee5f65591a6db2c989b3c7059e2f9d8 100644 --- a/module/VuFind/src/VuFind/Recommend/SwitchQuery.php +++ b/module/VuFind/src/VuFind/Recommend/SwitchQuery.php @@ -151,7 +151,6 @@ class SwitchQuery implements RecommendInterface // Perform all checks (based on naming convention): $methods = get_class_methods($this); - $checks = array(); foreach ($methods as $method) { if (substr($method, 0, 5) == 'check') { $currentCheck = strtolower(substr($method, 5));