From f347c167f81fb24db96c22939c0926effc364388 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Fri, 28 Feb 2014 10:02:52 -0500
Subject: [PATCH] Added tests.
---
.../Controller/Plugin/NewItemsTest.php | 223 ++++++++++++++++++
1 file changed, 223 insertions(+)
create mode 100644 module/VuFind/tests/unit-tests/src/VuFindTest/Controller/Plugin/NewItemsTest.php
diff --git a/module/VuFind/tests/unit-tests/src/VuFindTest/Controller/Plugin/NewItemsTest.php b/module/VuFind/tests/unit-tests/src/VuFindTest/Controller/Plugin/NewItemsTest.php
new file mode 100644
index 00000000000..fa528d9bf93
--- /dev/null
+++ b/module/VuFind/tests/unit-tests/src/VuFindTest/Controller/Plugin/NewItemsTest.php
@@ -0,0 +1,223 @@
+<?php
+
+/**
+ * New items controller plugin tests.
+ *
+ * PHP version 5
+ *
+ * Copyright (C) Villanova University 2010.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * @category VuFind2
+ * @package Tests
+ * @author Demian Katz <demian.katz@villanova.edu>
+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
+ * @link http://vufind.org/wiki/vufind2:unit_tests Wiki
+ */
+
+namespace VuFindTest\Controller\Plugin;
+
+use VuFind\Controller\Plugin\NewItems;
+use VuFindTest\Unit\TestCase as TestCase;
+use Zend\Config\Config;
+
+/**
+ * New items controller plugin tests.
+ *
+ * @category VuFind2
+ * @package Tests
+ * @author Demian Katz <demian.katz@villanova.edu>
+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
+ * @link http://vufind.org/wiki/vufind2:unit_tests Wiki
+ */
+class NewItemsTest extends TestCase
+{
+ /**
+ * Test ILS bib ID retrieval.
+ *
+ * @return void
+ */
+ public function testGetBibIDsFromCatalog()
+ {
+ $flash = $this->getMock('Zend\Mvc\Controller\Plugin\FlashMessenger');
+ $config = new Config(array('result_pages' => 10));
+ $newItems = new NewItems($config);
+ $bibs = $newItems->getBibIDsFromCatalog(
+ $this->getMockCatalog(), $this->getMockParams(), 10, 'a', $flash
+ );
+ $this->assertEquals(array(1, 2), $bibs);
+ }
+
+ /**
+ * Test ILS bib ID retrieval with ID limit.
+ *
+ * @return void
+ */
+ public function testGetBibIDsFromCatalogWithIDLimit()
+ {
+ $flash = $this->getMock('Zend\Mvc\Controller\Plugin\FlashMessenger');
+ $flash->expects($this->once())->method('setNamespace')
+ ->with($this->equalTo('info'))->will($this->returnValue($flash));
+ $flash->expects($this->once())->method('addMessage')
+ ->with($this->equalTo('too_many_new_items'));
+ $config = new Config(array('result_pages' => 10));
+ $newItems = new NewItems($config);
+ $bibs = $newItems->getBibIDsFromCatalog(
+ $this->getMockCatalog(), $this->getMockParams(1), 10, 'a', $flash
+ );
+ $this->assertEquals(array(1), $bibs);
+ }
+
+ /**
+ * Test default ILS getFunds() behavior.
+ *
+ * @return void
+ */
+ public function testGetFundList()
+ {
+ $catalog = $this->getMock(
+ 'VuFind\ILS\Connection', array('checkCapability', 'getFunds'),
+ array(), '', false
+ );
+ $catalog->expects($this->once())->method('checkCapability')
+ ->with($this->equalTo('getFunds'))->will($this->returnValue(true));
+ $catalog->expects($this->once())->method('getFunds')
+ ->will($this->returnValue(array('a', 'b', 'c')));
+ $controller = $this->getMock('VuFind\Controller\SearchController');
+ $controller->expects($this->once())->method('getILS')
+ ->will($this->returnValue($catalog));
+ $newItems = new NewItems(new Config(array()));
+ $newItems->setController($controller);
+ $this->assertEquals(array('a', 'b', 'c'), $newItems->getFundList());
+ }
+
+ /**
+ * Test a single hidden filter.
+ *
+ * @return void
+ */
+ public function testGetSingleHiddenFilter()
+ {
+ $config = new Config(array('filter' => 'a:b'));
+ $newItems = new NewItems($config);
+ $this->assertEquals(array('a:b'), $newItems->getHiddenFilters());
+ }
+
+ /**
+ * Test a single hidden filter.
+ *
+ * @return void
+ */
+ public function testGetMultipleHiddenFilters()
+ {
+ $config = new Config(array('filter' => array('a:b', 'b:c')));
+ $newItems = new NewItems($config);
+ $this->assertEquals(array('a:b', 'b:c'), $newItems->getHiddenFilters());
+ }
+
+ /**
+ * Test various default values.
+ *
+ * @return void
+ */
+ public function testDefaults()
+ {
+ $config = new Config(array());
+ $newItems = new NewItems($config);
+ $this->assertEquals(array(), $newItems->getHiddenFilters());
+ $this->assertEquals('ils', $newItems->getMethod());
+ $this->assertEquals(30, $newItems->getMaxAge());
+ $this->assertEquals(array(1, 5, 30), $newItems->getRanges());
+ $this->assertEquals(10, $newItems->getResultPages());
+ }
+
+ /**
+ * Test custom range settings.
+ *
+ * @return void
+ */
+ public function testCustomRanges()
+ {
+ $config = new Config(array('ranges' => '10,150,300'));
+ $newItems = new NewItems($config);
+ $this->assertEquals(array(10, 150, 300), $newItems->getRanges());
+ }
+
+ /**
+ * Test custom result pages setting.
+ *
+ * @return void
+ */
+ public function testCustomResultPages()
+ {
+ $config = new Config(array('result_pages' => '2'));
+ $newItems = new NewItems($config);
+ $this->assertEquals(2, $newItems->getResultPages());
+ }
+
+ /**
+ * Test Solr filter generator.
+ *
+ * @return void
+ */
+ public function testGetSolrFilter()
+ {
+ $range = 30;
+ $expected = 'first_indexed:[NOW-' . $range .'DAY TO NOW]';
+ $newItems = new NewItems(new Config(array()));
+ $this->assertEquals($expected, $newItems->getSolrFilter($range));
+ }
+
+ /**
+ * Get a mock catalog object (for use in getBibIDs tests).
+ *
+ * @return \VuFind\ILS\Connection
+ */
+ protected function getMockCatalog()
+ {
+ $catalog = $this->getMock(
+ 'VuFind\ILS\Connection', array('getNewItems'), array(), '', false
+ );
+ $catalog->expects($this->once())->method('getNewItems')
+ ->with(
+ $this->equalTo(1), $this->equalTo(200),
+ $this->equalTo(10), $this->equalTo('a')
+ )
+ ->will(
+ $this->returnValue(
+ array('results' => array(array('id' => 1), array('id' => 2)))
+ )
+ );
+ return $catalog;
+ }
+
+ /**
+ * Get a mock params object.
+ *
+ * @param int $idLimit Mock ID limit value
+ *
+ * @return \VuFind\Search\Solr\Params
+ */
+ protected function getMockParams($idLimit = 1024)
+ {
+ $params = $this
+ ->getMock('VuFind\Search\Solr\Params', array(), array(), '', false);
+ $params->expects($this->once())->method('getLimit')
+ ->will($this->returnValue(20));
+ $params->expects($this->once())->method('getQueryIDLimit')
+ ->will($this->returnValue($idLimit));
+ return $params;
+ }
+}
\ No newline at end of file
--
GitLab