From ec512ca16e8f1040bda92dbcb5b61ba45548beab Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Wed, 13 May 2015 10:06:01 -0400
Subject: [PATCH] Corrected false checks to null.
---
.../VuFind/src/VuFind/Role/PermissionProvider/ServerParam.php | 2 +-
module/VuFind/src/VuFind/Role/PermissionProvider/Shibboleth.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/module/VuFind/src/VuFind/Role/PermissionProvider/ServerParam.php b/module/VuFind/src/VuFind/Role/PermissionProvider/ServerParam.php
index 615f0751eab..b072b4a54e4 100644
--- a/module/VuFind/src/VuFind/Role/PermissionProvider/ServerParam.php
+++ b/module/VuFind/src/VuFind/Role/PermissionProvider/ServerParam.php
@@ -144,7 +144,7 @@ class ServerParam implements PermissionProviderInterface,
// server param values to check
$serverParamString = $this->request->getServer()->get($serverParamName);
- if ($serverParamString === false) {
+ if ($serverParamString === null) {
// check fails if server param is missing
return false;
}
diff --git a/module/VuFind/src/VuFind/Role/PermissionProvider/Shibboleth.php b/module/VuFind/src/VuFind/Role/PermissionProvider/Shibboleth.php
index a7c9953a088..efbb30997fb 100644
--- a/module/VuFind/src/VuFind/Role/PermissionProvider/Shibboleth.php
+++ b/module/VuFind/src/VuFind/Role/PermissionProvider/Shibboleth.php
@@ -74,7 +74,7 @@ class Shibboleth extends ServerParam
*/
public function getPermissions($options)
{
- if ($this->request->getServer()->get('Shib-Identity-Provider') === false) {
+ if ($this->request->getServer()->get('Shib-Identity-Provider') === null) {
$this->logWarning('getPermissions: Shibboleth server params missing');
return [];
--
GitLab