From d75783df52b7e8ddd0666e7b8fd0b2b6c74a3135 Mon Sep 17 00:00:00 2001
From: ckaz <kazzer@uni-leipzig.de>
Date: Fri, 5 Jun 2020 17:19:07 +0200
Subject: [PATCH] refs #17602 [finc VF5.x] rearranges SCSS

* rearranges some SCSS declarations for better clarity
---
 themes/finc/scss/compiled.scss | 109 ++++++++++++++++++---------------
 1 file changed, 61 insertions(+), 48 deletions(-)

diff --git a/themes/finc/scss/compiled.scss b/themes/finc/scss/compiled.scss
index 033fdc5a516..c6710dd5c3f 100644
--- a/themes/finc/scss/compiled.scss
+++ b/themes/finc/scss/compiled.scss
@@ -460,6 +460,41 @@ select {
 // IDs
 
 // CLASSES (Elements that are used in several places)
+//// BUTTONS
+////// Transparent buttons (button with border and darker text on light or white BGs)
+.btn-transparent {
+  @include button-variant($btn-transparent-color, $btn-transparent-bg, $btn-transparent-border);
+
+  &:hover,
+  &:focus {
+    color: lighten($btn-transparent-color, 80%);
+  }
+}
+
+////// Bookbag Toggler
+.sidebar .btn-bookbag-toggle {
+  width: 100%;
+}
+
+// Overwrites BS.scss setting! Keep padding same as '.record-nav > li > a' or "Add to Bookbag" in Record View will be out of line
+.nav .btn-bookbag-toggle a {
+  padding: $record-view-toolbar-button-padding 0;
+
+  @media (max-width: $screen-sm-max) {
+    padding: $record-view-toolbar-button-padding;
+  }
+}
+
+////// remove padding on SM up
+.btn-bookbag-toggle {
+  @media (max-width: $screen-xs-max) {
+    text-align: left;
+  }
+}
+
+////// Bookbag Toggler - END
+//// BUTTONS - END
+
 //// DROPDOWNS
 //// remove padding as it creates space above/below menu items (e.g. language selector)
 //// remove box shadow
@@ -527,16 +562,6 @@ select {
   width: 1em;
 }
 
-//// Transparent BUTTONs (Button with border and darker text on light or white BGs)
-.btn-transparent {
-  @include button-variant($btn-transparent-color, $btn-transparent-bg, $btn-transparent-border);
-
-  &:hover,
-  &:focus {
-    color: lighten($btn-transparent-color, 80%);
-  }
-}
-
 //// Accordion / Collapse
 ////// Toggler BG and arrow
 .accordion-toggler {
@@ -1680,7 +1705,7 @@ footer {
       // hide last and first page buttons
       &.first,
       &.last,
-      // select 7th to 11th child
+        // select 7th to 11th child
       &:nth-child(n+10):nth-child(-n+13) {
         display: none;
       }
@@ -1961,23 +1986,31 @@ footer {
 }
 
 //// Style facets to have the same height as items in myresearch-menu
-.facet-group .facet,
-.facet-group .title {
-  padding: $sidebar-item-padding;
-}
+.facet-group {
+  .facet,
+  .title {
+    padding: $sidebar-item-padding;
+  }
 
-.facet-group .facetOR.active {
-  // Style active facets to get proper left padding
-  .text {
-    text-indent: -3px;
+  .facetOR.active {
+    // Style active facets to get proper left padding
+    .text {
+      text-indent: -3px;
+    }
   }
-}
 
-.facet-group:not(.active-filters) .title {
-  &:hover,
-  &:focus {
-    background-color: $button-title-hover-bg;
-    @include outline(1px);
+  &:not(.active-filters) .title {
+    &:hover,
+    &:focus {
+      @include outline(1px);
+      background-color: $button-title-hover-bg;
+    }
+  }
+
+  ////// Pull exclude facets to the right, align with accordion/collapse triangles and headings
+  .facet.excludable {
+    padding-left: 1.5em;
+    padding-right: .5em;
   }
 }
 
@@ -1993,11 +2026,6 @@ footer {
   }
 }
 
-////// Pull exclude facets to the right, align with accordion/collapse triangles and headings
-.facet-group .facet.excludable {
-  padding-left: 1.5em;
-  padding-right: .5em;
-}
 
 //// Offcanvas is used to widths of 767px ($screen-xs-max)
 @media only screen and (max-width: $screen-xs-max) {
@@ -2117,14 +2145,6 @@ footer {
   width: 100%;
 }
 
-////// remove padding on SM up
-@media (max-width: $screen-xs-max) {
-  .record-nav > li > a,
-  .btn-bookbag-toggle {
-    text-align: left;
-  }
-}
-
 @media (min-width: $screen-sm-min) {
   .nav-stacked.nav > li > a {
     padding-left: 0;
@@ -2138,16 +2158,9 @@ footer {
   padding: $record-view-toolbar-button-padding;
 }
 
-.sidebar .btn-bookbag-toggle {
-  width: 100%;
-}
-
-// Overwrites BS.scss setting! Keep padding same as '.record-nav > li > a' or "Add to Bookbag" in Record View will be out of line
-.nav .btn-bookbag-toggle a {
-  padding: $record-view-toolbar-button-padding 0;
-
-  @media (max-width: $screen-sm-max) {
-    padding: $record-view-toolbar-button-padding;
+.record-nav > li > a {
+  @media (max-width: $screen-xs-max) {
+    text-align: left;
   }
 }
 
-- 
GitLab