diff --git a/module/VuFind/src/VuFind/Cover/Generator.php b/module/VuFind/src/VuFind/Cover/Generator.php index 8587ef505b77a2f58a896ae7d42b652fb66f97f6..f06aa6b308e7692adb3d04aab60c6e9ed18eb318 100644 --- a/module/VuFind/src/VuFind/Cover/Generator.php +++ b/module/VuFind/src/VuFind/Cover/Generator.php @@ -109,7 +109,7 @@ class Generator $this->black = imagecolorallocate($im, 0, 0, 0); // Generate seed from callnumber, title back up - $seed = $this->createSeed($title, $author, $callnumber); + $seed = $this->createSeed($title, $callnumber); // Number to color, hsb to control saturation and lightness $grid_color = $this->makeHSBColor( $im, @@ -143,12 +143,11 @@ class Generator * Generates a dynamic cover image from elements of the book * * @param string $title Title of the book - * @param string $author Author of the book * @param string $callnumber Callnumber of the book * * @return integer unique number for this record */ - protected function createSeed($title, $author, $callnumber) + protected function createSeed($title, $callnumber) { // Turn callnumber into number if (null == $callnumber) { diff --git a/module/VuFind/src/VuFind/ILS/Driver/Demo.php b/module/VuFind/src/VuFind/ILS/Driver/Demo.php index 1998053b1603511a4877e583becdcb72d2e872c7..1489276018898b0bc34bda38cc1d140625bf76d2 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/Demo.php +++ b/module/VuFind/src/VuFind/ILS/Driver/Demo.php @@ -843,6 +843,7 @@ class Demo extends AbstractBase * placeHold, minus the patron data. * * @return int + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getHoldDefaultRequiredDate($patron, $holdInfo) { diff --git a/module/VuFind/src/VuFind/ILS/Driver/LBS4.php b/module/VuFind/src/VuFind/ILS/Driver/LBS4.php index bf31d07e759b9f34358c8088761388641d9a2ca6..d8b7fdf3184b479deb5334e10b2fb3c489c6bfd1 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/LBS4.php +++ b/module/VuFind/src/VuFind/ILS/Driver/LBS4.php @@ -345,6 +345,7 @@ class LBS4 extends AbstractBase implements TranslatorAwareInterface * @param array $callnumber The callnumber of the item * * @return string On success, a string to be displayed near the item + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function getNote($loanind, $locid, $callnumber) { diff --git a/module/VuFind/src/VuFind/RecordDriver/Factory.php b/module/VuFind/src/VuFind/RecordDriver/Factory.php index 920286a12aacfd0618abbad2919d6a869611c1b2..19da5e21660e578a8477318bb8b336b5d4e0e48e 100644 --- a/module/VuFind/src/VuFind/RecordDriver/Factory.php +++ b/module/VuFind/src/VuFind/RecordDriver/Factory.php @@ -42,11 +42,9 @@ class Factory /** * Factory for LibGuides record driver. * - * @param ServiceManager $sm Service manager. - * * @return LibGuides */ - public static function getLibGuides(ServiceManager $sm) + public static function getLibGuides() { return new LibGuides(); } diff --git a/module/VuFind/src/VuFind/RecordDriver/Primo.php b/module/VuFind/src/VuFind/RecordDriver/Primo.php index 61ccba7b36a5254a562f078bc1d997cec8acc3a8..8e5d9e9baab0903701c819a228651ee5b2975e67 100644 --- a/module/VuFind/src/VuFind/RecordDriver/Primo.php +++ b/module/VuFind/src/VuFind/RecordDriver/Primo.php @@ -298,6 +298,7 @@ class Primo extends SolrDefault * @param string $format Export format * * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function exportDisabled($format) { diff --git a/module/VuFindAdmin/src/VuFindAdmin/Controller/TagsController.php b/module/VuFindAdmin/src/VuFindAdmin/Controller/TagsController.php index a7f6d4ac1b326d3b1d786499ab3b20c7181ddf3d..cee44137e556551a1e780179e0cee9506c55933c 100644 --- a/module/VuFindAdmin/src/VuFindAdmin/Controller/TagsController.php +++ b/module/VuFindAdmin/src/VuFindAdmin/Controller/TagsController.php @@ -169,7 +169,7 @@ class TagsController extends AbstractAdmin } if (false === $confirm) { - return $this->confirmTagsDelete($tags, $ids, $originUrl, $newUrl); + return $this->confirmTagsDelete($ids, $originUrl, $newUrl); } $delete = $tags->deleteByIdArray($ids); @@ -194,14 +194,13 @@ class TagsController extends AbstractAdmin /** * Confirm Delete by Id * - * @param object $tagModel A tag object * @param array $ids A list of resource tag Ids * @param string $originUrl An origin url * @param string $newUrl The url of the desired action * * @return $this->confirmAction */ - protected function confirmTagsDelete($tagModel, $ids, $originUrl, $newUrl) + protected function confirmTagsDelete($ids, $originUrl, $newUrl) { $messages = array(); $count = count($ids); diff --git a/module/VuFindSearch/src/VuFindSearch/Backend/LibGuides/QueryBuilder.php b/module/VuFindSearch/src/VuFindSearch/Backend/LibGuides/QueryBuilder.php index aa2a86ff4c57091a691b865f04b3b755830de5ea..2c831a534fbae4c9e0dc03443653a664db58bc9a 100644 --- a/module/VuFindSearch/src/VuFindSearch/Backend/LibGuides/QueryBuilder.php +++ b/module/VuFindSearch/src/VuFindSearch/Backend/LibGuides/QueryBuilder.php @@ -97,6 +97,7 @@ class QueryBuilder * @param QueryGroup $query QueryGroup to convert * * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function queryGroupToArray(QueryGroup $query) {