From ca9dfa9d6873167e923b69c98bd604c8cd2f6f5b Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Wed, 12 May 2021 08:35:58 +0200
Subject: [PATCH] refs #19447 [finc] remove getJournalHoldingsSolr in
SolrMarcFincTrait
* remove unused getJournalHoldingsSolr in SolrMarcFincTrait
* code styles for FincIls
---
module/finc/src/finc/ILS/Driver/FincILS.php | 11 ++---
.../finc/RecordDriver/SolrMarcFincTrait.php | 47 -------------------
2 files changed, 5 insertions(+), 53 deletions(-)
diff --git a/module/finc/src/finc/ILS/Driver/FincILS.php b/module/finc/src/finc/ILS/Driver/FincILS.php
index ae3a88631dd..edf613808c1 100644
--- a/module/finc/src/finc/ILS/Driver/FincILS.php
+++ b/module/finc/src/finc/ILS/Driver/FincILS.php
@@ -1384,10 +1384,10 @@ class FincILS extends PAIA implements LoggerAwareInterface
array_values($this->staticStatusRules['rules']),
(array)$this->staticStatusRules['stopFlags']
);
- $context = array(
+ $context = [
'authenticator' => $this->auth,
- 'record' => $this->getRecord($id),
- );
+ 'record' => $this->getRecord($id)
+ ];
$context = $eval($context);
return [[
'id' => $id,
@@ -1425,16 +1425,15 @@ class FincILS extends PAIA implements LoggerAwareInterface
*/
protected function hasILSData($id)
{
- $retVal = [];
foreach ($this->config['General']['queryIls'] as $value) {
list($methodName, $methodReturn) = explode(':', $value);
// if we have one mismatch we can already stop as this record does
// not qualify for querying the ILS
if ($methodReturn === "") {
- if (!is_null($this->getRecord($id)->tryMethod($methodName))) {
+ if (null !== $this->getRecord($id)->tryMethod($methodName)) {
return false;
}
- } elseif (!in_array($methodReturn, (array) $this->getRecord($id)->tryMethod($methodName))) {
+ } elseif (!in_array($methodReturn, (array)$this->getRecord($id)->tryMethod($methodName))) {
return false;
}
}
diff --git a/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php b/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
index c6f054f10d1..a81cf67cd39 100644
--- a/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
+++ b/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
@@ -728,53 +728,6 @@ trait SolrMarcFincTrait
return $matches;
}
- /**
- * Get an array of information about Journal holdings realised for the
- * special needs of University library of Chemnitz. MAB fields 720.
- * Refs #328
- *
- * @return array
- */
- public function getJournalHoldings()
- {
- $retval = [];
- $match = [];
-
- $fields = $this->getMarcRecord()->getFields('971');
- if (!$fields) {
- return [];
- }
-
- $key = 0;
- foreach ($fields as $field) {
- if ($subfield = $field->getSubfield('k')) {
- preg_match(
- '/(.*)##(.*)##(.*)/',
- trim($subfield->getData()),
- $match
- );
- $retval[$key]['callnumber'] = trim($match[1]);
- $retval[$key]['holdings'] = trim($match[2]);
- $retval[$key]['footnote'] = trim($match[3]);
- $retval[$key]['is_holdable'] = 1;
-
- if (count($this->getBarcode()) == 1) {
- $current = $this->getBarcode();
- $barcode = $current[0];
- } else {
- $barcode = '';
- }
- $retval[$key]['link'] =
- '/Record/' . $this->getUniqueID()
- . '/HoldJournalCHE?callnumber='
- . urlencode($retval[$key]['callnumber'])
- . '&barcode=' . $barcode;
- $key++;
- }
- }
- return $retval;
- }
-
/**
* Return a local access number for call number.
* Marc field depends on library e.g. 975 for WHZ.
--
GitLab