diff --git a/module/VuFind/src/VuFind/ILS/Driver/Demo.php b/module/VuFind/src/VuFind/ILS/Driver/Demo.php index 07809d19e066fbe226dc7225eaa4786002844e4e..860c6f59b6ad6632ab2cb1672bddb7209bbaba05 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/Demo.php +++ b/module/VuFind/src/VuFind/ILS/Driver/Demo.php @@ -322,6 +322,8 @@ class Demo extends AbstractBase * * @return mixed A boolean false if no blocks are in place and an array * of block reasons if blocks are in place + * + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getRequestBlocks($patron) { @@ -336,6 +338,8 @@ class Demo extends AbstractBase * * @return mixed A boolean false if no blocks are in place and an array * of block reasons if blocks are in place + * + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getAccountBlocks($patron) { diff --git a/module/VuFind/src/VuFind/ILS/Driver/KohaILSDI.php b/module/VuFind/src/VuFind/ILS/Driver/KohaILSDI.php index dbbc9389dbdbd510b4e9eab54ceaf19f34701392..88c8cb847e28c8b08793449e2677c3f930d26ea1 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/KohaILSDI.php +++ b/module/VuFind/src/VuFind/ILS/Driver/KohaILSDI.php @@ -274,7 +274,7 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements $this->debug("XML is not valid, URL: $url"); throw new ILSException( - "XML is not valid, URL: $url method: $method answer: $answer." + "XML is not valid, URL: $url method: $http_method answer: $answer." ); } return $result; @@ -533,7 +533,6 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements */ public function placeHold($holdDetails) { - $rsvLst = []; $patron = $holdDetails['patron']; $patron_id = $patron['id']; $request_location = isset($patron['ip']) ? $patron['ip'] : "127.0.0.1"; @@ -667,8 +666,7 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements $holding = []; $available = true; $duedate = $status = ''; - $loc = $shelf = ''; - $reserves = "N"; + $loc = ''; $sql = "select i.itemnumber as ITEMNO, i.location, COALESCE(av.lib_opac,av.lib,av.authorised_value,i.location) AS LOCATION, @@ -1466,7 +1464,6 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements } $sqlStmt = $this->db->prepare($sql); $sqlStmt->execute(); - $result = []; foreach ($sqlStmt->fetchAll() as $rowItem) { $deptList[$rowItem["abv"]] = $rowItem["DEPARTMENT"]; } @@ -1497,7 +1494,6 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements } $sqlStmt = $this->db->prepare($sql); $sqlStmt->execute(); - $result = []; foreach ($sqlStmt->fetchAll() as $rowItem) { $instList[$rowItem["borrowernumber"]] = $rowItem["name"]; } @@ -1527,7 +1523,6 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements } $sqlStmt = $this->db->prepare($sql); $sqlStmt->execute(); - $result = []; foreach ($sqlStmt->fetchAll() as $rowItem) { $courseList[$rowItem["course_id"]] = $rowItem["course"]; } @@ -1555,7 +1550,6 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements */ public function findReserves($course, $inst, $dept) { - $recordList = []; $reserveWhere = []; $bindParams = []; if ($course != '') { @@ -1614,8 +1608,6 @@ class KohaILSDI extends \VuFind\ILS\Driver\AbstractBase implements */ public function patronLogin($username, $password) { - $patron = []; - // $idObj = $this->makeRequest( // "AuthenticatePatron" . "&username=" . $username // . "&password=" . $password diff --git a/module/VuFind/src/VuFind/ILS/Driver/VoyagerRestful.php b/module/VuFind/src/VuFind/ILS/Driver/VoyagerRestful.php index ea5a9fd884deafb70e5e40da6b851e1b84d3426c..aaff992d788bc14d5045777a9b50b4665988712c 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/VoyagerRestful.php +++ b/module/VuFind/src/VuFind/ILS/Driver/VoyagerRestful.php @@ -850,6 +850,8 @@ class VoyagerRestful extends Voyager implements \VuFindHttp\HttpServiceAwareInte * * @return array False if request groups not in use or an array of * associative arrays with id and name keys + * + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getRequestGroups($bibId, $patron, $holdDetails = null) { diff --git a/module/VuFind/src/VuFind/Log/Writer/Post.php b/module/VuFind/src/VuFind/Log/Writer/Post.php index 178825edbeffd1d6eb7f5c8543ebf89279442d15..ab1cc838b03ecef472d4e2c0b5dcd42b8980762c 100644 --- a/module/VuFind/src/VuFind/Log/Writer/Post.php +++ b/module/VuFind/src/VuFind/Log/Writer/Post.php @@ -119,6 +119,6 @@ class Post extends \Zend\Log\Writer\AbstractWriter $this->client->setEncType($this->contentType); $this->client->setRawBody($this->getBody($this->applyVerbosity($event))); // Send - $response = $this->client->send(); + $this->client->send(); } } diff --git a/module/VuFind/src/VuFind/Search/Factory/PrimoBackendFactory.php b/module/VuFind/src/VuFind/Search/Factory/PrimoBackendFactory.php index 67d9e280136275e1832f15447d34b81c8e2f0001..b423e134f5959380a8ea0df2b0dee4f22ae93984 100644 --- a/module/VuFind/src/VuFind/Search/Factory/PrimoBackendFactory.php +++ b/module/VuFind/src/VuFind/Search/Factory/PrimoBackendFactory.php @@ -91,7 +91,7 @@ class PrimoBackendFactory implements FactoryInterface $connector = $this->createConnector(); $backend = $this->createBackend($connector); - $this->createListeners($backend); + $this->createListeners(); return $backend; } @@ -114,11 +114,9 @@ class PrimoBackendFactory implements FactoryInterface /** * Create listeners. * - * @param Backend $backend Backend - * * @return void */ - protected function createListeners(Backend $backend) + protected function createListeners() { $events = $this->serviceLocator->get('SharedEventManager'); diff --git a/module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php b/module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php index 6e627ca7fe28ea6a96ca94f176552db8d281a8e4..e07720c86737c6a4f57afbc58194bd3b5f6b7e7c 100644 --- a/module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php +++ b/module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php @@ -248,6 +248,8 @@ class RecordDataFormatter extends AbstractHelper * @param array $options Rendering options. * * @return string + * + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function renderSimple(RecordDriver $driver, $data, array $options) {